-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-15142: Page-specific Q&A Report #15833
Conversation
GitHub Workflows (.github/workflows/*.yml)Have you...
|
4cfb3df
to
9c2998c
Compare
9c2998c
to
4cb497f
Compare
@chri5tia still not seeing Benefit Detail Pages show up in the Tugboat instance here. Can you confirm what's happening with that before merging? |
79c18e0
to
15f96c5
Compare
@jilladams Can you check again? I didn't push the changes that fixed it until after your comment. |
@chri5tia does this look how you expect it to? https://pr15833-80d0prfrxp0pohhtro3rzzrlo2bjdxih.ci.cms.va.gov/admin/content/qa I'm seeing:
@thejordanwood should probably weigh in, but I feel like we need to modify a style here to make this usable if we're going to include every single page-specific Q&A in the results. The way it works now, you could have a single table row taking up most of the page / scroll, and the identifying info about the row is middle-aligned, so you have to scroll a long way to see it. If we updated this table to make table cells top-aligned, the UX to navigate the report would be better. That could be a style plugged in somewhere in custom modules that we already have that style tables, I think. You'd need to scope it to apply to just this report, though. I don't know if this violates CMS style rules. Thinking something like:
The alternative would be to not print every single Q&A, which keeps rows shorter. Is it a big lift to display a count instead? Like: how many page-specific Q&As exist on that node? |
b808d38
to
e2aac24
Compare
@jilladams @thejordanwood @dsasser Can you both take a look, this is truly ready for a review now, as far as I can tell.
As we discussed in Slack, this is a view of questions so that the list can be paired as individual questions are moved/migrated to the Reusable Q&A template. In this way, page specific content can be addressed by the content team in their own way as well. Please let me know if I missed anything and if it looks good, I will reach out to CAIA to take a look. Thanks for all your help and work on this. |
@chri5tia once you get approvals we can go ahead and merge, and share the Production link to the report with CAIA for feedback (that's implied in the AC re: sending Prod link). No need to get feedback in the Tugboat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Relates to #15142
This is a content report at /admin/content/qa to show all Page-specific Q&A content that uses that template.
Note: There is Q&A-related text in other places (using other types of main content blocks like rich text and accordions) that did not use the paragraph template for page-specific Q&As, such as on the Resources and Support content types. This PR and report does not cover those instances.
Testing done
Local functional
QA steps
Log in as a user with the access that CAIA content team has.
Navigate to /admin/content/qa.
Content is populated for the following node types, with approximately 1836 total, give or take, will be a little different because of varying test data.
Ensure that you are able to:
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?