Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15142: Page-specific Q&A Report #15833

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

chri5tia
Copy link
Contributor

@chri5tia chri5tia commented Oct 24, 2023

Description

Relates to #15142

This is a content report at /admin/content/qa to show all Page-specific Q&A content that uses that template.
Note: There is Q&A-related text in other places (using other types of main content blocks like rich text and accordions) that did not use the paragraph template for page-specific Q&As, such as on the Resources and Support content types. This PR and report does not cover those instances.

Testing done

Local functional

QA steps

Log in as a user with the access that CAIA content team has.
Navigate to /admin/content/qa.
Content is populated for the following node types, with approximately 1836 total, give or take, will be a little different because of varying test data.

  • 737 Benefit Detail Questions
  • 31 CMS KB Article Questions
  • 85 CLP Questions
  • 12 Centralized Content Questions
  • 970 VAMC Detail Questions

Ensure that you are able to:

  • click on a node to view the listed content
  • there are columns for section, node title and link, and node type

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 24, 2023 19:29 Destroyed
@github-actions
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 25, 2023 18:14 Destroyed
@chri5tia chri5tia force-pushed the VACMS-15142-Page-Specific-Q-A-CLP-Report branch from 4cfb3df to 9c2998c Compare October 25, 2023 18:24
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 25, 2023 18:24 Destroyed
@chri5tia chri5tia force-pushed the VACMS-15142-Page-Specific-Q-A-CLP-Report branch from 9c2998c to 4cb497f Compare October 25, 2023 18:36
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 25, 2023 18:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 25, 2023 19:00 Destroyed
@chri5tia chri5tia marked this pull request as ready for review October 25, 2023 19:00
@chri5tia chri5tia requested a review from dsasser October 25, 2023 19:00
@jilladams
Copy link
Contributor

@chri5tia still not seeing Benefit Detail Pages show up in the Tugboat instance here. Can you confirm what's happening with that before merging?

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 26, 2023 16:24 Destroyed
@chri5tia chri5tia force-pushed the VACMS-15142-Page-Specific-Q-A-CLP-Report branch from 79c18e0 to 15f96c5 Compare October 26, 2023 16:34
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 26, 2023 16:34 Destroyed
@chri5tia chri5tia requested a review from dsasser October 26, 2023 16:48
@chri5tia
Copy link
Contributor Author

@jilladams Can you check again? I didn't push the changes that fixed it until after your comment.

@jilladams
Copy link
Contributor

jilladams commented Oct 26, 2023

@chri5tia does this look how you expect it to? https://pr15833-80d0prfrxp0pohhtro3rzzrlo2bjdxih.ci.cms.va.gov/admin/content/qa

I'm seeing:

@thejordanwood should probably weigh in, but I feel like we need to modify a style here to make this usable if we're going to include every single page-specific Q&A in the results. The way it works now, you could have a single table row taking up most of the page / scroll, and the identifying info about the row is middle-aligned, so you have to scroll a long way to see it. If we updated this table to make table cells top-aligned, the UX to navigate the report would be better. That could be a style plugged in somewhere in custom modules that we already have that style tables, I think. You'd need to scope it to apply to just this report, though. I don't know if this violates CMS style rules. Thinking something like:

.view-display-id-page_qa  td {
  vertical-align: top; 
}

The alternative would be to not print every single Q&A, which keeps rows shorter. Is it a big lift to display a count instead? Like: how many page-specific Q&As exist on that node?

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 26, 2023 20:04 Destroyed
@chri5tia chri5tia force-pushed the VACMS-15142-Page-Specific-Q-A-CLP-Report branch from b808d38 to e2aac24 Compare October 26, 2023 22:58
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 26, 2023 22:58 Destroyed
@chri5tia
Copy link
Contributor Author

@jilladams @thejordanwood @dsasser Can you both take a look, this is truly ready for a review now, as far as I can tell.

  • blank entries have been removed
  • duplicate entries have been removed
  • other translations are now included

As we discussed in Slack, this is a view of questions so that the list can be paired as individual questions are moved/migrated to the Reusable Q&A template. In this way, page specific content can be addressed by the content team in their own way as well.

Please let me know if I missed anything and if it looks good, I will reach out to CAIA to take a look. Thanks for all your help and work on this.

@jilladams
Copy link
Contributor

jilladams commented Oct 26, 2023

I feel ok with shipping this and iterating as needed once CAIA has a chance to take a look.

@jilladams
Copy link
Contributor

@chri5tia once you get approvals we can go ahead and merge, and share the Production link to the report with CAIA for feedback (that's implied in the AC re: sending Prod link). No need to get feedback in the Tugboat.

Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

Screenshot 2023-10-27 at 9 42 52 AM

@chri5tia chri5tia merged commit b211d6c into main Oct 27, 2023
18 checks passed
@chri5tia chri5tia deleted the VACMS-15142-Page-Specific-Q-A-CLP-Report branch October 27, 2023 17:07
@chri5tia chri5tia mentioned this pull request Oct 27, 2023
3 tasks
@dsasser dsasser mentioned this pull request Nov 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants