D10 upgrade PR #14876
Merged
D10 upgrade PR #14876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 22, 2023 08:25
ndouglas
previously approved these changes
Nov 29, 2023
swirtSJW
reviewed
Nov 29, 2023
swirtSJW
reviewed
Nov 29, 2023
Comment on lines
+50
to
+52
| "drupal/core": "10.1.6 as 9.5", | ||
| "drupal/core-composer-scaffold": "10.1.6 as 9.5", | ||
| "drupal/core-recommended": "10.1.6 as 9.5", |
Comment on lines
+68
to
+69
| "drupal/entity_clone": "^2.0@alpha", | ||
| "drupal/entity_diff_ui": "1.0.x-dev@dev", |
There was a problem hiding this comment.
Is this regressing intentional? A little concerned about going backwards and requiring dev branch.
There was a problem hiding this comment.
yes these are necessary
Comment on lines
-20
to
+23
| $config['system.performance']['css']['preprocess'] = TRUE; | ||
| $config['system.performance']['css']['gzip'] = TRUE; | ||
| $config['system.performance']['js']['preprocess'] = TRUE; | ||
| $config['system.performance']['js']['gzip'] = TRUE; | ||
| $config['system.performance']['css']['preprocess'] = FALSE; | ||
| $config['system.performance']['css']['gzip'] = FALSE; | ||
| $config['system.performance']['js']['preprocess'] = FALSE; | ||
| $config['system.performance']['js']['gzip'] = FALSE; |
There was a problem hiding this comment.
Double checking that this is necessary.
We still need the |
ndouglas
approved these changes
Nov 29, 2023
dsasser
reviewed
Nov 29, 2023
| @@ -185,6 +187,7 @@ module: | |||
| path_redirect_import: 0 | |||
| pathologic: 0 | |||
| pfm: 0 | |||
| phpass: 0 | |||
There was a problem hiding this comment.
That is an unfortunate name for a module
dsasser
reviewed
Nov 29, 2023
docroot/modules/custom/va_gov_events/src/EventSubscriber/EntityEventSubscriber.php
Show resolved
Hide resolved
| @@ -51,7 +51,7 @@ class StaticEncoder implements SerializerAwareInterface, EncoderInterface { | |||
| * The string translation service. | |||
| */ | |||
| public function __construct(MessengerInterface $messenger, TranslationInterface $string_translation) { | |||
| $this->messenger = $messenger; | |||
| $this->messenger = $messenger; | |||
There was a problem hiding this comment.
CONSIDER:
This looks like a tab instead of spaces. Any reason we need a tab here? Nope, it is just a bunch of spaces. Any reason we should be having that many here?
| $form_state = $event->getFormState(); | ||
| $id = $form_state->getFormObject()->getFormId(); | ||
|
|
||
| if ($id === 'views_form_content_page_2') { |
There was a problem hiding this comment.
CONSIDER:
I would consider creating a separate method for each form alter with the assumption that we may have to modify other Views in the future, and a single method for all alters could become hard to manage over time.
Something like:
public function formAlter(FormAlterEvent $event): void {
$form = &$event->getForm();
$form_state = $event->getFormState();
$this->viewsFormContentPageTwoAlter(&$form, $form_state); // code from 25 and on would go here.
// Future form alter methods would go here.| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public static function getSubscribedEvents() { |
There was a problem hiding this comment.
CONSIDER/NITPICK:
getSubscribedEvents() should be the first method in the class so scrolling to find out what events are subscribed to is not necessary.
| @@ -0,0 +1,6 @@ | |||
| <?php | |||
There was a problem hiding this comment.
SHOULD:
Thile .module file is not necessary.
There was a problem hiding this comment.
CONSIDER:
Is this empty file needed?
There was a problem hiding this comment.
CONSIDER:
Is this empty file necessary?
There was a problem hiding this comment.
CONSIDER:
Is this empty file necessary?
dsasser
approved these changes
Nov 29, 2023
tjheffner
pushed a commit
that referenced
this pull request
Dec 6, 2023
* VACMS-12453: refactoring fro samlauth module * VACMS-12453: more refacotring for samlauth module * VACMS-12252: latest d10, merged main into d10 branch * VACMS-12453: config split setup for samlauth * VACMS-12453: removed simplesamlphp config files * VACMS-00000: remove drupal/flysystem modules * VACMS-12252: merged latest from main * VACMS-12252: additional updates, added simplasamlphp shell modules * VACMS-12252: more contrib patches * VACMS-12252: updated composer.lock * VACMS-12252: update to ckeditor5 config * VACMS-12252: update nodejs to v18 for core, commiting updated patch file * VACMS-12252: removed imports in stroybook from core claro * VACMS-12252: changes for theme d10 compatibility * VACMS-12252: added samlauth config for tugboat * VACMS-12453: samlauth config for tugboat * VACMS-12252: commiting patch for storage * VACMS-12252: replaced jquery.once in va_gov_backend with once * VACMS-12252: needed dependencies for testing, added explicitly * VACMS-12453: samlauth config for local * ACMS-12252: fix for accesCheck in phpunit test * VACMS-12453: fix for user import, this is handle by samlauth module now * VACMS-12252: enable password compatibility module * VACMS-12252: updates for graphqlv3 module * VACMS-12252: updates to cypress for ckeditor5 * VACMS-12252: fixed dependencies * VACMS-12252: updates for js once to fix cypress tests * VACMS-12453: fix for cypress test of user login scren * VACMS-12252: updated accessibility.js to disabled aria-allowed-attr * VACMS-12252: js updates for vanilla once * VACMS-14359: Replaces deprecated code in PdfCheckValidator.php. * VACMS-0000: Removes unnecessary property definition which is now defined in the parent class. This was throwing a php error during site rebuild. * VACMS-0000: Updates encode() method signature to match parent class method signature. * VACMS-12252: update or textfield_counter module * VACMS-12252: fix for cypress tests * VACMS-12453: fixed config to remove simplesamlphp_auth * VACMS-12453: fix for user.login test and reenable va_gov_multilingual * VACMS-12252: fix for multilingual * VACMS-12252: fix for step_definitions cypress test * VACMS-12252: fix for person_profile cypress test * VACMS-14434: Resolves 'The element must be an instance of Element'. * VACMS-12252: fix for tooltip, added popperjs library * VACMS-12252: fix for gtm * VACMS-12252: fix for media and step_definition cypress tests * VACMS-12252: patch for paragraphs_browser to use once library * VACMS-14480: removed GTM * VACMS-12453: certificate updates * VACMS-12252: fix for cypress test * VACMS-14481: Some tweaks to build-frontend.sh script. * VACMS-14550: WIP updated guzzle client * VACMS-12252: removed gtm from va_gov_backend.libraries.yml * VACMS-12252: updated composer.lock * VACMS-12252: patch for vbo for access failure * VACMS-12252: updated composer.lock * VACMS-12252: missed a few accessChecks * VACMS-12252: updated composer.lock * VACMS-14591: fixed va logo in the toolbar * VACMS-14550: Makes ContentReleaseStatusControllerTest D10-compatible. * VACMS-12573: fix for widget form alter syntax change * VACMS-14538: fix for js once syntax change * VACMS-12252: fix to classy library change * VACMS-14489: fix for link autocomplete * VACMS-14556: fix for vbo Apply button styling * VACMS-11003: ifx syntax of .info.yml file * VACMS-14556: fix for vbo form * VACMS-12252: type in composer.json * VACMS-12252: fix for cypress test * VACMS-14556: vbo module update * VACMS-14635: fix for contacts selection para * VACMS-12252: updated composer.lock * VACMS-12252: added accessCheck * VACMS-12252: fix for cypress test * VACMS-14725: simplasamlphp upgrade and config * VACMS-12252: fix for cypress test * VACMS-14725: config fix * VACMS-14725: removed shell module, i'm an idiot * VACMS-14725: symlink updated for simplesamlphp * VACMS-14725: updated simplesamlphp config * VACMS-14725: updated simplesamlphp * VACVMS-12252: updatd to 10.1.2 * VACMS-14725: config update * VACMS-14725: another update for simplesamlphp * VACMS-14725: update 3 simplesamlphp * VACMS-14725: update to simplesamlphp_auth module * VACMS-14725: trying to fix css/js * VACMS-14725: turn off aggregation * VACMS-14725: trying to fix css/js * VACMS-14725: turn off aggregation * VACMS-12252: updated composer.lock * VACMS-12252: patch for entity_reference_hierarchy * VACMS-12252: updated composer.lock * VACMS-14556: styling new vbo bulk edit form * VACMS-12252: fixes from linting * VACMS-12252: temp ignore vamc operating status and alerts test * VACMS-14556: fix for vbo form styling * VACMS-14556: fix for VBO form styling * VACMS-12252: updated composer.lock * VACMS-12252: syntax fix for dependencies * VACMS-12561: fix for ckeditor5 toolbar sticky z-index * VACMS-12252: updated composer.lock * VACMS-12252: minor syntax changes and updtes * VACMS-12252: updated composer.lock * VACMS-12252: fix for syntax booboos * VACMS-12252: updated composer.lock, fixed another syntax booboo * VACMS-12252: updated composer.lock * VACMS-12252: updated composer.lock * VACMS-12634: fix for smart date field in events * VACMS-12252: smart_date to 4.0.3 * VACMS-14725: updates * VACMS-14725: updates to composer.lock * VACMS-14725: fix for simplesamlphp * VACMS-14725: updated composer.lock * VACMS-14725: updated composer.lock * Revert "VACMS-14725: fix for simplesamlphp" This reverts commit 95ebfae. * VCMS-14725: updated composer.lock * VACMS-12252: update composer.lock * VACMS-14725: updates for simplesamplphp * VACMS-12252: updated composer.lock * VACMS-12252: core and contrib module updates * VACMS-12634: fix for smart date field on add new event * VACMS-15135: remove button styles from ckeditor5 * VACMS-12634: fix manual editable tags * VACMS-12252: updated composer.lock * VACMS-12252: updated composer.lock * VACMS-12252: upgrade to core 10.1.4 * VACMS-12252: updated composer.lock * VACMS-14725: update simplesamlphp to rc1 * VACMS-12252: updated composer.lock * VACMS-15112: fixed ckeditor styling * VACMS-12252: updated composer.lock * VACMS-12252: update nodejs version to 18 in theme build script * VACMS-12252: update nodejs version to 18 in theme build script * VACMS-14725: updated simmplesaml_auth to rc1 * VACMS-14725: adjust settings for simplesamlphp * VACMS-14725: remove unneeded patch * VACMS-14725: remove unneeded patch * VACMS-12252: fix for csv_serialization update * VACMS-14725: updated composer.lock * VACMS-12252: update for modules * VACMS-12252: updated composer.lock * VACMS-12252: updates to composer.json to remove merged patches * VACMS-16017: removed deprecation * VACMS-12252: updated composer.lock * VACMS-12252: fix for views_data_export version * VACMS-12252: updated composer.lock * VACMS-12252: patch for views_conditional modules * VACMS-12252: enable intl php extension * VACMS-12252: install php ext intl * VACMS-12252: remove patch for views_conditional * VACMS14643: fix ckeditor5 height * VACMS-16098: fix for ckediotr width * VACMS-12252: updated composer.lock * VACMS-12252: fix for composer.json * VACMS-16107: workaround for styling links in ckeditor5 not working * VACMS-16111: fix for theming of abbreviations in ckeditor * VACMS-16126: fixed alignment of calendar checkbox * VACMS-16139: fix for block content route * VACMS-16123: added IDs back into ckeditor5 config * VACMS-16119: fis for LSBE field showing on content section on KB article * VACMS-12252: updated composer.lock * VACMS-16119: final fix for LSBE field in KB articles * Adds '::save' in custom submission handler for nodes. * VACMS-12252: updated composer.lock * VACMS-12252: update simplesamlphp_auth, remove outdated patch * ACMS-12252: update to sitewide_alert patch * VACMS-12252: updated composer.lock * VACMS-12252: fix for RequestStack, changed to Symfony * VACMS-12252: updated composer.lock * VACMS-12252: fix for stylelint error --------- Co-authored-by: Daniel Sasser <[email protected]> Co-authored-by: Nathan Douglas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #16018
Testing done
Tested int eh base preview.
Screenshots
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
Tested per testing plan.
Definition of Done
Select Team for PR review
CMS TeamPublic websitesFacilitiesUser supportAccelerated PublishingIs this PR blocked by another PR?
DO NOT MERGEDoes this PR need review from a Product Owner
Needs PO reviewCMS user-facing announcement
Is an announcement needed to let editors know of this change?