Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text validation to appointment custom text in Service Location #17124

Open
11 tasks
omahane opened this issue Feb 1, 2024 · 1 comment
Open
11 tasks

Add text validation to appointment custom text in Service Location #17124

omahane opened this issue Feb 1, 2024 · 1 comment
Labels
CY24-Q2 Calendar year Q2 2024 priority Drupal engineering CMS team practice area Enhancement Issue type: New feature or request Facilities Facilities products (VAMC, Vet Center, etc) points-8 sitewide

Comments

@omahane
Copy link
Contributor

omahane commented Feb 1, 2024

User Story or Problem Statement

As an editor, I would like to have validation on the Custom text field of the Appointment information in the Service Location so that I can ensure that I have filled out that field before I save the page.

Context

Prior to the Service Location being the source of truth for Appointment text type and custom text, the VAMC Facility Health Service had these fields and validated the presence of text in the Custom text field if "Custom text" was chosen for the Appointment text type.

Implementation steps

The likely area to add this code would be va_gov_facilities_field_widget_single_element_paragraphs_form_alter in va_gov_facilities.module.

Some code is captured in this branch: VACMS-17124-add-text-validation-custom-appt-text-serv-loc

Screenshots

Screenshot 2024-02-01 at 12 47 38 PM Screenshot 2024-02-01 at 12 49 13 PM

Acceptance Criteria

  • When saving a service of any of the 4 applicable content types, should the Appointment introduction text field be set to "Customize text" and Custom text textbox should show as required.
  • Appropriate error messages are displayed in error scenatrios
  • Should the Customize text be selected and the Custom text be empty, the node should not save.
  • Should Javascript be disabled, server-side validation should prevent the node from being saved.
  • The above should be true for the following content types:
    • Service Region
    • VAMC Facility Health Service
    • VAMC Facility Non-Clinical Service
    • VBA Facility Service
  • Requires design review
  • Requires accessibility review
@omahane omahane added Enhancement Issue type: New feature or request Needs refining Issue status labels Feb 1, 2024
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Feb 1, 2024
@omahane omahane changed the title Add text validation to appointment custom test in Service Location Add text validation to appointment custom text in Service Location Feb 1, 2024
@xiongjaneg xiongjaneg added the Drupal engineering CMS team practice area label Mar 19, 2024
@davidmpickett davidmpickett removed the Needs refining Issue status label Mar 21, 2024
@davidmpickett
Copy link
Contributor

Unlikely that this will get pulled in to Sprint 2 given that this is hefty and there's a good chunk of higher priority tickets on the docket, but will leave it here until Sprint Planning next week for official call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CY24-Q2 Calendar year Q2 2024 priority Drupal engineering CMS team practice area Enhancement Issue type: New feature or request Facilities Facilities products (VAMC, Vet Center, etc) points-8 sitewide
Projects
None yet
Development

No branches or pull requests

4 participants