Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAMC Locations: adopt V1 and V3 components where components are not used #16964

Closed
1 of 8 tasks
laflannery opened this issue Jan 22, 2024 · 8 comments
Closed
1 of 8 tasks
Assignees
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@laflannery
Copy link
Contributor

laflannery commented Jan 22, 2024

Description

VAMC Location pages need the following updates to components:

Example pages:

List of Components

Elements that are not using components that should be (Backlog)

  1. Link
    • Facility names should use the link component
    • All "Get Directions" links (Main location, Health clinics, Other locations) need to be updated to use the v1 component
  2. Telephone
    • The main location number and the phone numbers for Health clinics are not using a component and should be updated to use the aria-describedby v1 component
    • The numbers under "Other nearby VA locations" are using the proper component but should be updated to use the aria-describedby variant
    • Exts in all phone numbers should be parsed correctly within the component
  3. Back to top component
    • Update 5/3: After determining that this component does not actually have built in intelligence to only show based on page height:
      • This should still be added, the Locations pages are typically longer so having this on these pages will probably make sense more often than not.

Acceptance Criteria

  • Back to top component has been added
  • Update and run existing test(s).
  • If additional tests are needed, stub a ticket to note this for future work.
  • Requires accessibility review

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@laflannery laflannery added Needs refining Issue status VAMC CMS managed product owned by Facilities team VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) accessibility Issues related to accessibility labels Jan 22, 2024
@maxx1128
Copy link

I estimate this ticket at a 3 for moving over a good amount of relatively simple elements over to components.

@xiongjaneg xiongjaneg removed the Needs refining Issue status label Feb 28, 2024
@laflannery
Copy link
Contributor Author

FYI I removed the Link component from the scope of this ticket because we can't use this in Get Directions links

@jilladams jilladams changed the title Update VAMC Locations template with components Update VAMC Locations template with components (v1) Mar 27, 2024
@jilladams jilladams changed the title Update VAMC Locations template with components (v1) VAMC Locations: adopt V1 and V3 components where components are not used Mar 27, 2024
@laflannery
Copy link
Contributor Author

Telephone update moved to #16148

@eselkin
Copy link
Contributor

eselkin commented Apr 24, 2024

Probably a 3, but could consider a 5 given that it has two PRs and updates a React component
Updating src/site/includes/facilityListing.drupal.liquid
Also updating widget "other-facility-locations-list"

@laflannery
Copy link
Contributor Author

@eselkin If this is 2 PRs and it would make more sense to break up this ticket into the individual pieces for each of those PRs we can do that as well, if it makes more sense

@eselkin
Copy link
Contributor

eselkin commented Apr 24, 2024

It's one display so keep as one ticket @laflannery

@randimays
Copy link
Contributor

A design tweak was merged in for this ticket this morning. We missed the deployment window, though, so this'll be in production tomorrow around lunchtime.

@randimays
Copy link
Contributor

I thought we missed the deployment window but maybe the deployment lagged today? Our design tweak is in production and has been validated successfully. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

7 participants