-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAMC Locations: adopt V1 and V3 components where components are not used #16964
Comments
I estimate this ticket at a 3 for moving over a good amount of relatively simple elements over to components. |
FYI I removed the Link component from the scope of this ticket because we can't use this in Get Directions links |
Telephone update moved to #16148 |
Probably a 3, but could consider a 5 given that it has two PRs and updates a React component |
@eselkin If this is 2 PRs and it would make more sense to break up this ticket into the individual pieces for each of those PRs we can do that as well, if it makes more sense |
It's one display so keep as one ticket @laflannery |
A design tweak was merged in for this ticket this morning. We missed the deployment window, though, so this'll be in production tomorrow around lunchtime. |
I thought we missed the deployment window but maybe the deployment lagged today? Our design tweak is in production and has been validated successfully. Closing! |
Description
VAMC Location pages need the following updates to components:
Example pages:
List of Components
Elements that are not using components that should be (Backlog)
All "Get Directions" links (Main location, Health clinics, Other locations) need to be updated to use the v1 componentTelephoneThe main location number and the phone numbers for Health clinics are not using a component and should be updated to use thearia-describedby
v1 componentThe numbers under "Other nearby VA locations" are using the proper component but should be updated to use thearia-describedby
variantExts in all phone numbers should be parsed correctly within the componentAcceptance Criteria
Team
Please check the team(s) that will do this work.
The text was updated successfully, but these errors were encountered: