VACMS-16964 VAMC Locations web components #29634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/16964-vamc-locations-wc/16964-vamc-locations-wc
va-vfs-bot
temporarily deployed
to
master/16964-vamc-locations-wc/16964-vamc-locations-wc
randimays
force-pushed
the
16964-vamc-locations-wc
branch
from
45b7a8f to
9c0380b
Compare
randimays
force-pushed
the
16964-vamc-locations-wc
branch
from
9c0380b to
047cc84
Compare
randimays
commented
May 8, 2024
| @@ -29,11 +29,6 @@ describe('facilities <OtherFacilityListWidget>', () => { | |||
| tree.update(); | |||
| expect(tree.find('va-loading-indicator').exists()).to.be.false; | |||
|
|
|||
| const facilityName = tree.find('h3'); | |||
There was a problem hiding this comment.
This has to be removed because now its contents are a web component and we can't assert on the shadow DOM in unit tests.
|
LGTM |
agravell047
pushed a commit
that referenced
this pull request
May 9, 2024
agravell047
added a commit
that referenced
this pull request
May 13, 2024
* removed code + update breadcrumb * added link for mobile * removed link * updated links * updated tests * update tests * cypress fixes * MHV-58096/revert-rx-breadcrumbs * Direct Veterans to call their provider/facility to update contact (#29623) * direct Veterans to call their provider/facility to update contact * update unit test * adjusting for tests * adjusting for tests * adjusting for tests? * change href to <a> element * fix for href * fix for test * fix for test? * add accessibility items * swap out va-link for a element * update link * Vye 381 login accounts alert (#29659) * VYE-381 added login alert for direct dopist when user login without using ID.me * fixed failling usint tests * fixed failling cypress tests * 82689 - [CDP] - Aria Va-Row Attribute Missing Breaking Tests (#29672) * Remove table role as there is no precedent in app for using it with platform component and any combination of rowgroup and row roles inside it did not satisfy test. * Fix broken unit test * About Medications page: In the event the API call fails, we need to p… (#29210) * About Medications page: In the event the API call fails, we need to provide an error * e2e error message for list page api added test to validate error message for list page api call failure * fix the bug on breadcrumb * e2e refill page api call added test to verify error message for refill page api call failure * resolve the feedback * resolve the feedback * display the error message when api call fails * unit test fix * unit test fix * e2e updates test updates to include network and element locators * unit test error * eslint fix * eslint error * eslint fix --------- Co-authored-by: raji.venkatesh <[email protected]> * Removed account number from copay summary page as it's unique to each va location (#29678) * added email transform (#29670) * added primary contact info to submit transformer (#29679) * update-rx-icons (#29664) * updated icons * updated icons * removed unnecessary text * adjusted keynames and added some logging (#29646) * Add textUI textareaUI + mock form cleanup (#29658) * add textUI and textareaUI * cleanup mock form * VACMS-16964 VAMC Locations web components (#29634) * [mhv-57073] added spacing to about page. (#29647) * [mhv-57073] added spacing according to ucd specifications. * [mhv-57073] added left and right spacing to all pages. * [mhv-57073] fixed issue with top margin on h2 found by ucd after validating. * [mhv-57073] used small screen breakpoint instead of medium screen for h1. * Re-enable VAOS skipped tests (#29595) * Re-enable all skipped tests * Fix UpcomingAppointmentList tests * Remove redundant UrlAndPageTitleChange tests * Remove redundant TextareaWidget test * Re-enable ReasonForAppointmentPage test * Remove duplicated test with identical ids * Fix TypeOfVisitPage tests * Fix ClosestCityStatePage tests * Remove CommunityCarePreferencesPage tests * Fix flaky test * Fix CommunityCareProviderSelectionPage tests * Fix flaky TypeOfVisitPage tests * Update ClinicChoicePage tests * Skip flaky test * Add note for VAFacilityPage test * Fix DateTimeSelectPage tests * Re-enable skipped tests * Revert test change for CI * Fix last DateTimeSelectPage test * Address feedback * Update test issue link * Remove AppointmentCard * Consolidate and rename AppointmentPage unit tests * Update reducer logic * added back link to details page for desktop view * updated tests, added link for desktop details page * fixed scss * removed specific styles for mobile link * breadcrumb e2e fixes * adding their relationship to vet page (#29621) * MHV-57564: About Medications content and layout updates (#29611) * MHV-57564: About Medications content and layout updates * Layout update (lost in merge) * MHV-57108: "Show medications in this order" should span the width of the field and button below * Add UploadPage and basic uploading functionality (#29657) * Add UploadPage and basic uploading functionality * add scss file * Use different uploader and add tests * Remove reducers * remove a test * Use history.goBack instead of redirect * fix downtime banners (#28727) * MBMS-43498 Pre-need-integration non veteran military history updates (#29630) * MBMS-43498 Pre-need-integration non veteran military history updates * MBMS-43498 Initial version of complete content changes * MBMS-43498 POR/UI/UX Review changes * MBMS-43498 Fixed unit tests * 82039 improve unit test coverage for form 10-7959c (#29613) * simplified schema access in form config * added some title/depends testing * improved coverage of depends functions * updated documentation on missingfile comp * removed unused constants, added tests for transformers + missingfileoverview * render test for confirmation page + removed unnecessary conditonals * helper unit tests * more coverage * added readme and updated test to check certifier branch * more coverage * final coverage * fix array builder alert issues (#29715) * fix array builder alert issues * [CST] - Created diagram and new overview header (#29707) * created diagram and new overview header * add tests and add feature flag * add tests * updated SIP messaging and fixed SSN bug with prefill (#29720) * MHV-57094 All text should be aligned and not start under the checkboxes (#29654) * MHV-57094 resolve the feedback * resolve the feedback * - remove duplicate API endpoint calls (#29719) (for future appointments and unread messages) - cleanup * Ask VA 878 - Design Changes for Relationships - "More about your relationship to the Veteran" (#29638) * updated Veteran date of death page UI and test * update UI per figma, add test file, rename according to figma description * removed styles --------- Co-authored-by: Aaron Read <[email protected]> Co-authored-by: James Zaccardo <[email protected]> Co-authored-by: wafimohamed <[email protected]> Co-authored-by: Brandyn Sullins <[email protected]> Co-authored-by: gerard-sullivan <[email protected]> Co-authored-by: raji.venkatesh <[email protected]> Co-authored-by: Joseph Lee <[email protected]> Co-authored-by: Michael Clement <[email protected]> Co-authored-by: Robert Hasselle <[email protected]> Co-authored-by: Randi Mays <[email protected]> Co-authored-by: robertbylight <[email protected]> Co-authored-by: John Luo <[email protected]> Co-authored-by: Edwin Otero <[email protected]> Co-authored-by: Vitalii Menshutin <[email protected]> Co-authored-by: Eric Tillberg <[email protected]> Co-authored-by: Caitlin <[email protected]> Co-authored-by: ConnorJeff <[email protected]> Co-authored-by: Peri-Ann McLaren <[email protected]> Co-authored-by: allisonlu <[email protected]> Co-authored-by: Hemesh Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert facilities names to
<va-link>in theOther nearby VA locationssection of the Locations page.Also adds a space to the alert at the bottom of the page that shows when the service fails. We needed a space before the link.
Related issue(s)
Testing done
Tested
/huntington-health-care/locations/locally. This is only for theOther nearby VA locationssectionScreenshots
va-link
Bug fix - space between text and link
Before
After