Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder items under "ABOUT [SYSTEM NAME]" in VAMC menus to match CAIA guidance #16233

Closed
2 tasks done
davidmpickett opened this issue Nov 28, 2023 · 13 comments
Closed
2 tasks done
Assignees
Labels
Drupal engineering CMS team practice area Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding Facilities Facilities products (VAMC, Vet Center, etc) Menus [CMS feature] sitewide VAMC CMS managed product owned by Facilities team

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Nov 28, 2023

User Story or Problem Statement

When getting IA guidance for Police Transparency, we also got a request to standardize the order of VAMC menu items in the ABOUT [SYSTEM NAME] sub menu.

ABOUT [SYSTEM NAME]

  • About us
  • Programs (if enabled)
  • Research (if enabled)
  • Policies (or Privacy and policies)
  • VA police
  • Work with us
  • Contact us

Private Zenhub Image

Acceptance Criteria

  • Menu items are in the order specified
  • Submenu items follow their parent accordingly
@davidmpickett davidmpickett added Facilities Facilities products (VAMC, Vet Center, etc) Menus [CMS feature] Needs refining Issue status VAMC CMS managed product owned by Facilities team Drupal engineering CMS team practice area Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding labels Nov 28, 2023
@swirtSJW
Copy link
Contributor

swirtSJW commented Dec 2, 2023

police and policies on adjacent lines is not great for scanning and recognition as they only differ by an 'i' (least visibly distinct character there is)

@swirtSJW
Copy link
Contributor

swirtSJW commented Dec 7, 2023

Related upstream module issue https://www.drupal.org/project/codit_menu_tools/issues/3406650

@xiongjaneg
Copy link
Contributor

ready for Drupal refinement, will need Dave P. to review along the way

@swirtSJW
Copy link
Contributor

swirtSJW commented Feb 5, 2024

This is a bit of a pain. Some of our menus don't follow the pattern of "____-health-care" because the names are too long :(

image

@swirtSJW
Copy link
Contributor

swirtSJW commented Feb 9, 2024

Upstream issues completed:

I will create a new release of the module in the morning after one final round of testing.

@swirtSJW
Copy link
Contributor

swirtSJW commented Feb 9, 2024

There are some menu naming anomalies that I fixed on prod.

  1. Altoona -> Contact Us changed to Contact us
  2. Durham -> Contact Us changed to Contact us
  3. Lebanon -> Contact Us changed to Contact us

@swirtSJW
Copy link
Contributor

swirtSJW commented Feb 9, 2024

This is an odd one.
image

The menu does exist with that machine name But it is empty /admin/structure/menu/manage/va-leavenworth-health-care

I am guessing this was an old one that got renamed.

@swirtSJW
Copy link
Contributor

swirtSJW commented Feb 9, 2024

Yep Leavenworth was coalesced to kansas and the menu was never removed. #4943

I'll have to remove the menu from config as part of this PR :(

Need to remove topeka too :(

@swirtSJW
Copy link
Contributor

swirtSJW commented Feb 9, 2024

Menus that are already correct, to be used to validate they don't break:

  • There are none in the right order :(

Menus that are currently out of order:

  • /washington-dc-health-care
  • /spokane-health-care
  • /greater-los-angeles-health-care
  • /orlando-health-care
  • and all the others... they are all out of order.

@swirtSJW
Copy link
Contributor

Running the script (CMS Devops) and fixing Lovell by hand (Facilities engineer) are covered by #17202

@swirtSJW
Copy link
Contributor

The initial script was run twice on prod but kept failing due to running out of memory. #17236 Should solve the problem so that #17202 can be completed.

@jilladams
Copy link
Contributor

Have pinged on #17202 to clarify whether the CMS Team has run the required script in prod yet or not. If so: this ticket will be unblocked.

@xiongjaneg
Copy link
Contributor

Sort of a duplicate of #17202, which was verified as completed in prod as following the menu order
Screenshot 2024-03-06 at 10 01 39 AM
Screenshot 2024-03-06 at 10 01 52 AM
Screenshot 2024-03-06 at 10 02 11 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding Facilities Facilities products (VAMC, Vet Center, etc) Menus [CMS feature] sitewide VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

4 participants