VACMS-16233 Reorder VAMC menus

[swirtSJW]

Description

Relates to #16233

Acceptance Criteria

• from Reorder items under "ABOUT [SYSTEM NAME]" in VAMC menus to match CAIA guidance #16233
  • Menu items are in the order specified
  • Submenu items follow their parent accordingly
• from Create Eastern Kansas menu, delete Topeka and Leavenworth. #4943
  • Remove VA Topeka health care menu in
  • Remove VA Leavenworth health care menu

Screenshots

Prod (old busted) on left, PR (new hotness) on right

QA steps

1. Not required but if you want to see the ~520 lines of new code added to codit:menu tools module you can see it here .

2. Go to the tugboat dashboard and click on the php terminal link.

   • Run the command drush scr ./scripts/content/VACMS-16233-reorder-vamc-menu-items.php
   • validate you see something like
     

3. Go get lunch... it is going to run for ~ an hour on tugboat.

4. When it is complete:

   • Validate you see a message like
     

5. Go to System Washington DC

   • validate that the primary menu items under "About SYSTEM health care" match the following pattern

     About us
     Programs
    Research
    Policies
    VA police
    Work with us
    Contact us
   

6. Go to System Spokane

   • validate pattern match ^^

7. Go to System Greater Los Angeles

   • validate pattern match ^^

8. Go to System Orlando

   • validate pattern match ^^

9. Go to System Lovell

   • validate pattern match ^^

10. Login as admin

11. Go to dblog filtered for codit menu tools

    • validate you only see 6 notices. They are from misnamed menu items that have already had their names fixed on prod, but tugboat's db does not have the fix yet.

12. Go to the menu admin

• Validate that no menu exists with the word 'topeka' in it (have to check all 4 paginations)
• Validate that no menu exists with the word 'leavenworth' in it (have to check all 4 paginations)

Definition of Done

• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.

[github-actions]

GitHub Workflows (.github/workflows/*.yml)

Have you...

• pinned all affected GitHub Actions at a specific commit by SHA?
• reviewed the source code of the action at the commit you are pinning?
• confirmed that no GitHub security measures are being bypassed?
• checked for any injection of user content into protected contexts?
• reviewed Security hardening for GitHub Actions?
• reviewed GitHub Workflows?

[swirtSJW]

Takes about 38 minutes to run

So has to be moved to a script.

[swirtSJW]

@omahane @Becapa This file you already fully reviewed on the service location migration PR into the integration branch. I just cherry-picked the commit into this PR because I needed it.

CMS team, since this was cherry picked from an integration branch it does have a couple functions in it that are not used by this PR but are used by the code in the integration branch that can not be merged yet.

[swirtSJW]

Removed because it conflated new node with new revision.

[swirtSJW]

Running the script (CMS Devops) and fixing Lovell by hand (Facilities engineer) are covered by #17202

[omahane]

QA checks out and VA code looks great and super clean, i.e. codit is doing most of the work. (Note: I didn't check the codit code).

[swirtSJW]