-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Events "See more events" link to use more descriptive links #15766
Comments
@laflannery FYI, ticketed. |
@thejordanwood @jilladams Will you please review the AC I added and let me know if I captured what the original ticket was asking for? Also, one of the associated tickets indicates they want this by Veterans Day. Is that possible considering we just started a new sprint last week, and Veteran's Day is next Friday? Thanks a bunch! |
|
@jilladams @FranECross Do we need anything from me for this ticket? I'm fine with the Mural board treatment for this, but can add the design into this Sketch file if needed. |
@thejordanwood I don't think anything is needed. Unless @jilladams thinks otherwise I don't think you need to get this into Sketch, since we'll be soon moving things to Figma. What do you think of me adding a small story to the backlog to have the design put in Figma for historical purposes after we actually move over there? |
Good by. me! |
Thanks, @jilladams and @thejordanwood ! I'll link the Figma story to this ticket after I get it created. |
@FranECross Works for me. Thank you! |
Fran to collaborate with Jordan regarding verbiage and links. |
@thejordanwood I think that you altered the mural board after we all chatted about making the wording/links shorter and more generic, and having them display depending on what event they are looking at. Will you please look at the two scenarios below and let me know if they are the current designs to use for the ticket? Thanks! |
@FranECross check with Jordan and did I make the ticket? |
@FranECross you did! #15946 |
@FranECross I haven't had a chance to work on this ticket and haven't updated the Mural board. I'm not sure if someone else has updated the Mural since it was decided that the wording/links should be shorter and more generic. The designs themselves look fine to me, but I'm not sure who should approve the final wording for this. Any thoughts @jilladams? |
Asked Dave here - https://dsva.slack.com/archives/C52CL1PKQ/p1701363575880979. I'm not 100% certain. |
Dave responded that we don't need to reach out to CAIA, and that Jordan and Dave Pickett can come up with the wording. Slack message sent today https://dsva.slack.com/archives/C52CL1PKQ/p1701382788170309 |
@FranECross The copy ticket is slotted for Sprint 100. This one follows and is blocked by. |
This was pulled in as Stretch on 4/9 |
@FranECross Do we have analytics requirements for the two links that will be used? Right now, the existing "See more events" link just logs a "nav-secondary-button-click." |
@randimays Are the two links components that have the baked in analytic va-link? If so, I think we can get away with using that, since the destination will either be an event at a VAMC or on the outreach calendar. If not, then I can come up with custom events to capture. TIA! |
@FranECross They are both using va-link (which has the baked-in analytics), but we're still lacking the destination URL in that baked-in data. It seems like you are ok without it for now? |
Update: This has been taking longer than anticipated for a few reasons:
This will carry over to the next sprint. |
Thanks, @randimays ! I am okay with it for now, since they are (I believe) working on adding destination in their current or next sprint. |
Putting this into Blocked. We need a bit of Drupal work to send back the VAMC facility name (i.e. "Portland health care") so we can display it for this link:
Brief Slack discussion: https://dsva.slack.com/archives/C52CL1PKQ/p1713285657832429 @FranECross to create the Drupal ticket for this work |
@FranECross @randimays it looks like we might be able to get to the facility name by adding it to the graphql (it took me taking a much closer look at this to see that this was possible). Randi I pushed a commit to your branch that should bring it in. If you have questions or problems using it let me know, but we should be able to close #17888 as a no-op if the graphql change ends up being what we need. |
Removed Blocked label per Daniel completing/releasing the work needed for this ticket. |
Pulling in from stretch. |
Putting into Blocked temporarily as we're still not getting the correct data from Drupal with the added GraphQL. Daniel is helping to troubleshoot but content-build performance issues are slowing us down tremendously. This is at risk of not closing before end of sprint. Slack thread for troubleshooting: https://dsva.slack.com/archives/C52CL1PKQ/p1717618099488709 |
Pulled out of blocked. Daniel helped pull more GraphQL data to get the right VAMC name. Thanks @dsasser! |
This ticket is awaiting a11y and design review. Those are not marked as ACs on this ticket but since we had some design contributed for this ticket, I thought it'd be good to run it by Jordan and Laura. This will carry over to the next sprint since we won't make the prod deploy for today. |
@FranECross @randimays I commented this on the PR, but am going to add this here for visibility. I think there may be some confusion on how this needs to be implemented here.
|
@thejordanwood Gotcha; I'll make the updates! Thank you. |
Thank you, @thejordanwood and @randimays ! BTW I added a11y and design review items to the AC. |
This was delayed by the code freeze for the Juneteenth holiday and some content-build production deploy issues. But now these changes are in production and they have been successfully verified! Closing as complete. |
Status
[2024-06-03] Ticket no longer blocked.
[2024-04-24] This ticket blocked by a BE ticket that's Ready to be worked on.
Description
IA feedback: department-of-veterans-affairs/va.gov-team#67025
IA mural treatment
Update See more events at the foot of main content on events.
Want to see more events offered at Example VAMC?
[Go to VAMC events calendar]
Want to see more events offered by the VA across the country? (for Outreach events or VAMC+Outreach events only)
[Go to outreach events calendar]
ACs
AC1: When Veteran or other user is viewing an event at a particular VAMC, they see two links in order to view other events that are VAMC specific or Outreach
GIVEN: a Veteran or other user is viewing an Event at a specific VAMC on VA.gov
WHEN: the Veteran or other user looks toward the bottom of the event information on the screen
THEN: the Veteran or other user will see two links they can follow to other events:
AC2: When Veteran or other user is viewing an event on the Outreach calendar, they see only a link to view other Outreach events
GIVEN: a Veteran or other user is viewing an Outreach/National Event on VA.gov
WHEN: the Veteran or other user looks toward the bottom of the event information on the screen
THEN: the Veteran or other user will see a link they can follow to see the outreach/national calendar.
ACs added 2024-06-11:
Mural screens:
The text was updated successfully, but these errors were encountered: