-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update Events > Figma] Create a mockup in Figma for the 'See more events links' #15946
Comments
Copy Dave provided:
Variations
The one open design question here is which kind of link the link should should be (active vs. default) |
@FranECross @thejordanwood could we pull this into Sprint 102? Should be smallish, I think, and we're now unblocked on copy. |
If @thejordanwood doesn't object, I can tag for Sprint 102... Thanks @jilladams !! |
@FranECross We can add this to Sprint 102. |
@jilladams @FranECross I created mockups for this on the See more events page in the Figma file. The links should be the default style and I've added a header above them that says "Other VA events." This helps to align it with something similar we do for Other locations sections on Vet Center pages (example). @laflannery Can you review this design, specifically the new "Other VA events" heading level I'm suggesting? It's an h4, which is the same heading level used when the details section gets a heading. An example of this is the "Welcome to the Hampton Roads..." header on this event page. Is h4 the correct level I should be using here? |
@thejordanwood The page you took as an example has an incorrect heading level because that heading is defined within a text editor, not by us, and so shenanigans happened. If this should be a heading - which I think it should be - it should be an H2 because it's the only other defined heading on the page besides the main H1. If you would like to make the font size slightly smaller then the default H2 that would be ok though. Also, can you indicate in the figma that these links should use the |
@laflannery I had a feeling something about that heading wasn't quite right. Thanks for clarifying! I left a note that it should be an h2 with h3 styling–h2 styling felt a bit too big. I also added an annotation on the mockup to show that the link should be a component. |
@aklausmeier This is ready for your review. This design is showing how we can add links to other event calendars at the bottom of event detail pages. (Figma file link) |
@thejordanwood design and annotations look good |
Description
After we officially move from Sketch to Figma, create a prototype depicting the two links referenced in ticket #15766 : Update Events > See more events link to use more descriptive text.
Design
Outreach and events Figma file
User story
AS A person working on the VA.gov site in any given role (PO/PM/Delivery/Dev/UX, etc.)
I WANT to see a prototype in Figma for the new see more events links/text
SO THAT our future selves have visual reference of the work done
Update See more events at the foot of main content on events.
Want to see more events offered at Example VAMC?
[Go to [exampleVAMC] events calendar]
Want to see more events offered by the VA across the country? (for Outreach events or VAMC+Outreach events only)
[Go to outreach events calendar]
Acceptance criteria
GIVEN I'm a person who is working on the VA.gov website
WHEN I want to see what see more links were added in the linked story
THEN I can look in Figma to see a representation of what was build
The text was updated successfully, but these errors were encountered: