Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outreach & Events] Send back the facility name so it can be displayed on the FE in a link #17888

Closed
2 tasks
FranECross opened this issue Apr 17, 2024 · 2 comments
Closed
2 tasks
Assignees
Labels
Drupal engineering CMS team practice area Events product maintained by Public Websites team Public Websites Scrum team in the Sitewide crew sitewide

Comments

@FranECross
Copy link

FranECross commented Apr 17, 2024

Description

In support of the FE ticket "Update Events "See more events" link to use more descriptive links #15766", Drupal needs to send back the facility name so it can be displayed in links. As an example, VAMC facility name (i.e. "Portland health care")

Want to see more events offered at Example VAMC? [Go to VAMC events calendar]

Brief Slack discussion

Note: We know that the facility names don't match what's in Drupal, however we aren't going to try to fix that at this time. Another ticket will be created later to address that.

User story

AS A Veteran, their caregiver, family member or survivor
I WANT to see a user friendly (actual) facility name in the event link I click
SO THAT I'm not confused by a name different than what is noted in the event displaying in the link

Engineering notes / background

Analytics considerations

Quality / testing notes

Acceptance criteria

  • Include a graphQL snippet for the front-end
  • The front-end on VA.gov has access to the actual facility name
@FranECross FranECross added Drupal engineering CMS team practice area Needs refining Issue status Public Websites Scrum team in the Sitewide crew labels Apr 17, 2024
@FranECross
Copy link
Author

@randimays Here is the ticket for the drupal work in support of your see more events link FE ticket. I realized I should have had it ready for Sprint planning this morning. 🫤 @dsasser Will you please async refine this when you have a moment, and then I'll put it at the top of the Ready column, just in case you have bandwidth in the new sprint to take care of it. Thanks!

@FranECross FranECross changed the title Send back the facility name so it can be displayed on the FE in a link [Outreach & Events] Send back the facility name so it can be displayed on the FE in a link Apr 19, 2024
@FranECross FranECross removed the Needs refining Issue status label Apr 23, 2024
@FranECross FranECross added the Events product maintained by Public Websites team label May 1, 2024
@dsasser
Copy link
Contributor

dsasser commented May 13, 2024

Update 5/13/24

No code changes are necessary for this ticket. Instead, we can modify the existing Events queries to include the office title. Randi already has a branch with her pending FE changes, so I pushed the changes there.

diff --git a/src/site/stages/build/drupal/graphql/nodeEvent.graphql.js b/src/site/stages/build/drupal/graphql/nodeEvent.graphql.js
index cbc4d630b..c894e8d7a 100644
--- a/src/site/stages/build/drupal/graphql/nodeEvent.graphql.js
+++ b/src/site/stages/build/drupal/graphql/nodeEvent.graphql.js
@@ -132,6 +132,7 @@ const nodeEvent = `
               entityBundle
               entityId
               ... on NodeOffice {
+                title
                 fieldBody {
                   value
                   format
@@ -158,6 +159,7 @@ const nodeEvent = `
               entityBundle
               entityId
               ... on NodeOffice {
+                title
                 fieldBody {
                   value
                   format
@@ -331,6 +333,7 @@ const nodeEventWithoutBreadcrumbs = `
               entityBundle
               entityId
               ... on NodeOffice {
+                title
                 fieldBody {
                   value
                   format
@@ -357,6 +360,7 @@ const nodeEventWithoutBreadcrumbs = `
               entityBundle
               entityId
               ... on NodeOffice {
+                title
                 fieldBody {
                   value
                   format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Events product maintained by Public Websites team Public Websites Scrum team in the Sitewide crew sitewide
Projects
None yet
Development

No branches or pull requests

3 participants