-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] VBA services (batch 1) to Service Taxonomy #15748
Comments
Exporting current state of excel document |
I have consolidated the excel doc down to only the 11 services under consideration for batch 1 and put the RO feedback in main tab A nice validation that we made good choices in selecting the first batch is that all 11 services were marked as "This is a core service offering at my location" by RO respondent(s) |
@swirtSJW Incredibly specific question for you. Facility Locator v0 documentation has a list of benefit service codes as a sibling of the health services codes. Should we use these in the Health Service API ID field? Or is that field specifically connecting to the Health Services Only and not the Benefit Services? Or does this basically not matter since the only source of truth this would be linking up with is Sandy's DB which we are going to be replacing?
|
@swirtSJW Corollary question for lighthouse. Will anything break if some of these services ID don't have a service on our end? For instance we won't be using |
Pulling these two terms out of batch 1 because they need more discussion on the actual term name
|
@swirtSJW and @omahane - here's the official list terms to add and terms to update for y'all to review / implement New terms to add to VA Services
Existing terms that need to change
|
I updated the source of truth doc on sharepoint. I renamed the column "roadmap" to "GitHub ticket tracking this term." Adding static copy of that doc for quick reference: |
Also, gathered up all the terms that didn't already have a ticket into a new one: #16269 |
Added draft content for all VBA subfields for Veterans Pension - https://prod.cms.va.gov/health-care/veterans-pension |
@mmiddaugh @aklausmeier @xiongjaneg - for conversation on Monday morning 1 - Establishing Minimum Viable Signoff needed to Add new VA Service taxonomy terms to DrupalThe term label, machine name, and health service API ID are the only three fields that A) are required to create a new term and B) problematic to change once created. I have winnowed down this first batch to terms that:
My question for y'all
2 - Using Drupal as source of truth for final reviewsOnce a term is created Drupal by an admin, I will populate all the VBA subfields.
Then the term in Drupal can be sent to CAIA and VBA for final review/approval. Example: Veterans pension My questions for y'all
3 - What about non-VBA fields?I don't think this particular batch of terms will have much appeal to VAMC or Vet Center, but might be worth going through the motion of officially communicating the new terms availability and establish processes for them generating their product-specific content. 4 - Where are the rest of the VBA terms?
|
@davidmpickett In the meeting, you mentioned we might need a spike ticket for discovery post-MVP about care vs. service "at such-and-such Regional Office." Would you stub that please? We can discuss at our 1:1 if needed too. Thank you! |
@xiongjaneg Already stubbed - #15690 |
I am currently blocked on further progress on this ticket by two items
I defer to @swirtSJW and @omahane on whether 1 is a hard blocker to 2, or whether 2 could move forward while we wait for a response from Lighthouse (if it doesn't come during sync today) |
Thread involving LH on the question of benefit or health services |
From Adam:
|
@swirtSJW could you comment here today to clarify if an admin could go ahead and make the changes Dave listed, based on Adam's response? And Dave / Swirt, if you need help from an Admin, I'm available. |
I think @omahane has said he would grab this. |
I just added these. However I got to wondering about the casing on the api ids. Have these been approved by LH? |
The casing came from their documentation, but maybe there's a follow up ticket for you to confirm everything is working for them before we publish a VBA facility? Or is that part of #15366? |
@jilladams @xiongjaneg - this is going to continue into sprint 99 due to blockers and my thin capacity in 98 |
@xiongjaneg need a follow up ticket here. |
3 pts completedin 98, 2 pts in 99 |
|
Made good progress, but didn't quite get this across the line today |
@davidmpickett thank you for the helpful visual - it will support understanding with a variety of audiences For efficiency, I suggest we seek VBA input before requesting CAIA input - hopefully that will avoid additional back and forth - is this set ready for VBA input? Question: Are these accurate expectations for VBA service fields?
|
|
@mmiddaugh @xiongjaneg I think we should resolve this defect before sending the links for VBA. If y'all approve that as a sprint injection I can have a PR ready to merge today. |
@mmiddaugh @aklausmeier Now that bug fix has merged, these are ready to send to VBA for review / approval. Let me know if you need me to help in drafting any communication around that. I have listed out the Follow up approval and launch steps after the ACs. It is up to y'all and @xiongjaneg @jilladams whether you want to use this ticket to track that, or separate that out into a VBA Launch checklist or something else. |
@jilladams Let's talk at our 1:1 when we talked about talking about launch. Thank you! |
Ported those notes to the new ticket: #16445 |
@davidmpickett verified and closed defect ticket #16378 Is there anything else in this ticket awaiting PO/Prod review? |
Ready to close from my perspective, thank you! |
@mmiddaugh of the 9 terms that you took to VBA for review, the only one I've seen feedback on is Disability Compensation (which I implemented today) Does that mean the other 8 are all good from VBA's perspective and ready to send to CAIA for final approval? Or are you still waiting on feedback? cc @aklausmeier |
Which Taxonomy is this term for?
VA services taxonomy
Proposed term name/label
Does this overlap with any existing term in the taxonomy?
No
Rationale for adding this term
These terms are supported by multiple rounds of research as part of the VBA Regional Office MVP.
Which products will this term impact?
VBA Regional Office
Have stakeholders from impacted products been consulted?
Yes, Michelle has communicated with VBA and also gave VAMC a heads up
Have you drafted content for all the relevant subfields?
Acceptance Criteria (Sprint 98) - 5 points
### Follow up approval and launch steps (could be a separate ticket)moved to #16445The text was updated successfully, but these errors were encountered: