Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drupal users with View access should not be able to Edit the moderation state of a Taxonomy term #16378

Closed
1 task done
davidmpickett opened this issue Dec 12, 2023 · 2 comments
Closed
1 task done

Drupal users with View access should not be able to Edit the moderation state of a Taxonomy term #16378

davidmpickett opened this issue Dec 12, 2023 · 2 comments
Assignees
@davidmpickett
Labels
Defect Something isn't working (issue type) Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA services taxonomy CMS-managed product owned by the Facilities team

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Dec 12, 2023 •
edited by xiongjaneg
Loading

Describe the defect

When a Taxonomy term is in any state other than Published, a Moderation State widget shows up on Node View, allowing them to change the moderation state, even though they don't have normally have access to Node Edit.

It is unlikely that most users would stumble upon this, but as follow up to #15748 we will be sending direct links to unpublished Taxonomy terms to VBA stakeholders, so it would be good to resolve this.

This can be resolved by an admin dragging Moderation Control down to Disabled on Display config.

Screenshot 2023-12-11 183531

See #15695 for a more holistic approach to governance of Taxonomy Terms.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://staging.cms.va.gov/
  2. Log in as [email protected]
  3. Go to https://staging.cms.va.gov/health-care/life-insurance
  4. See error

AC / Expected behavior

  • The Moderation Control widget does not show up on Node View for VA Service Taxonomy terms

Screenshots

Screenshot 2023-12-11 182349

Screenshot 2023-12-11 182336
@davidmpickett davidmpickett added Defect Something isn't working (issue type) Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status labels Dec 12, 2023
@davidmpickett davidmpickett self-assigned this Dec 12, 2023
@davidmpickett davidmpickett changed the title Drupal users without section access should not be able to change moderation state of taxonomy term Random Drupal users should not be able to change moderation state of taxonomy term Dec 12, 2023
@davidmpickett davidmpickett added the VA services taxonomy CMS-managed product owned by the Facilities team label Dec 12, 2023
@davidmpickett davidmpickett changed the title Random Drupal users should not be able to change moderation state of taxonomy term Drupal users with View access should not be able to Edit the moderation state of a Taxonomy term Dec 12, 2023
@davidmpickett davidmpickett added Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding and removed Needs refining Issue status labels Dec 12, 2023
This was referenced Dec 12, 2023
Closed
Merged
@davidmpickett
Copy link
Contributor Author

Merged, pending prod verification

@xiongjaneg
Copy link
Contributor

Confirmed in staging the Moderation Control widget does not show up for this user
Screenshot 2023-12-14 at 3 00 34 PM
on Node View for VA Service Taxonomy terms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidmpickett davidmpickett

Labels
Defect Something isn't working (issue type) Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA services taxonomy CMS-managed product owned by the Facilities team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidmpickett @xiongjaneg @jilladams