Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front End template skeleton for Facility content type for VBA #14940

Closed
3 of 4 tasks
xiongjaneg opened this issue Aug 23, 2023 · 8 comments
Closed
3 of 4 tasks

Front End template skeleton for Facility content type for VBA #14940

xiongjaneg opened this issue Aug 23, 2023 · 8 comments
Assignees
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area

Comments

@xiongjaneg
Copy link
Contributor

xiongjaneg commented Aug 23, 2023

Description or Additional Context

Front End skeleton template for updates to VBA Facility content type per spec #13130

Resources

Assumption

Query is ready.

Acceptance Criteria

  • All needed data is pulling in from the query, except for data that is not available on the CMS. (part of the engineering 5 points)
  • The pages are rendering at the expected URL (not necessarily linked to other pages yet). (part of the engineering 5 points) -- URL is tbd from 10/11 meeting out of VBA Regional Office Information Architecture work #15490
  • Accessibility is reviewed by Laura (estimate 3 of the points)
  • Work is in a DO NOT MERGE PR, and ticket is moved to Complete Pending Integration
@xiongjaneg xiongjaneg added Needs refining Issue status Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team CMS frontend CMS team practice area VA.gov frontend CMS team practice area and removed CMS frontend CMS team practice area labels Aug 23, 2023
@xiongjaneg
Copy link
Contributor Author

xiongjaneg commented Sep 19, 2023

@xiongjaneg create next ticket. Edit: Done

@xiongjaneg xiongjaneg changed the title Front End template for VBA Facility content type Front End template skeleton for VBA Facility content type Sep 19, 2023
@xiongjaneg xiongjaneg changed the title Front End template skeleton for VBA Facility content type Front End template skeleton for Facility content type for VBA Sep 19, 2023
@xiongjaneg xiongjaneg removed the Needs refining Issue status label Sep 19, 2023
@maxx1128
Copy link

I started this ticket later in the sprint and have begun working on the code. It will carry over into the next sprint or whatever sprint we push it to.

@jilladams
Copy link
Contributor

Mid-sprint: Spotlights aren't coming through, centralized content, needs to be flattened. Max working on it today, will leave notes for Eli to follow up if that doesn't wrap today.

Then: last a11y review and ready to merge.

@jilladams
Copy link
Contributor

@eselkin reminder that this ticket includes A11y review, so when you feel like it's ready for @laflannery please ping her with pointer to the environment where she can take a look.

And Laura: FYI that in scrum today we discussed the fact that this ticket is really a skeleton, so lots of empty spaces where content will come later.

@jilladams
Copy link
Contributor

Discussed with Eli:

  • Review Instances keep 502ing.
  • Tugboat: Max has a tugboat with Cms content, and needs to be refreshed with content-build changes, so this may be a place for @laflannery to review, if that gets working.

Eli will holler if /when that gets working. Since this PR isn't going to merge ins print anyway, if the A11y review gets delayed, we could split it into its own ticket, to call this done. @xiongjaneg for awarenss in case this is where we land for end of sprint.

@jilladams
Copy link
Contributor

From scrum: this shouldn't merge to prod. We could put it behind a feature flag, but for now: can move to Complete Pending Integration.

@eselkin
Copy link
Contributor

eselkin commented Nov 3, 2023

@jilladams @xiongjaneg @laflannery I forgot to put a comment here, but it is now operational on Max's tugboat. The URL that is in the image on the PR is:
https://web-txcrk8bym4a0ivw3xfr8xvdhezmls36f.demo.cms.va.gov/vba-facilities/locations/seattle-regional-office/

@jilladams
Copy link
Contributor

For end of sprint:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants