Front end template for VBA Facility content type

[xiongjaneg]

Description or Additional Context

Front End template for updates to VBA Facility content type per spec #13130

Resources

• Refer to VBA Content Specs XLS linked in VBA Pilot MVP - Drupal content modeling & spec work #13096
• Sketch file

Assumption

Query is ready.

Acceptance Criteria

• Work should be based on Front End template skeleton for Facility content type for VBA #14940, which is not merged to main yet.
• The front end shown matches the design file to a reasonably accurate extent.
• Any applicable unit or component testing is completed.
• Any refinements to the front end have been stubbed out in tickets.
• Requires design review
• Requires accessibility review
• PR merged to va-14940-vba-facility-content-skeleton which is effectively now an integration branch.

[jilladams]

@xiongjaneg FYI that Eli flagged he'll have capacity to pick up something new, so this is next likely candidate. Holler with any concerns. Pulled into S96.

[eselkin]

@laflannery for the phone numbers, I'm assuming we should use a va-telephone component. However, there is https://design.va.gov/storybook/?path=/docs/components-va-telephone--aria-described-by#aria-described-by which has an aria-described-by id. Should we be using that and wrapping a span around Main phone and referring to it in the va-telephone? We have 2 phone numbers, the main and the benefits number on the page.

[laflannery]

@eselkin Thanks for finding this, I think in the way back of my mind I knew this was available but definitely didn't remember. Here's the situation:

• Unfortunately this is not working as it is intended, I'm going to file a DST bug
• It's not a critical accessibility error, it's would really benefit users and definitely a nice to have though
  • I would also want to make a backlog ticket to track the DST and update our pages when an update is available.
• Our other facility pages do not use this (only Facility locator does I believe?)
  • Our other facility pages don't use any telephone component yet tbh
• My recommendation would be to use the basic/standard/default telephone component for now. Reasons would be:
  • I don't want to create tech debt by adding custom HTML for just a nice to have feature
  • I don't want to add the aria-describedby telephone component when I know it doesn't currently work and I don't know how/when exactly it would be updated to make it work. (i.e. I don't know for certain updates will just automagically occur and we won't have to do anything on our end)

I would like to know how you, @mmiddaugh and @xiongjaneg feel about my thoughts/recommendation though

CC: @aklausmeier for design system awareness

[xiongjaneg]

@laflannery Your considerations and recommendation make sense to me. Thanks for being thorough in your explanation.

[aklausmeier]

@laflannery really like the idea for our team to track the bug fix

I would also want to make a backlog ticket to track the DST and update our pages when an update is available.

[jilladams]

Noting: one outstanding Q for CAIA on this issue: department-of-veterans-affairs/content-build#1790 (comment) where we need clarification on how to handle the external VBA scheduling link.

"make an appointment" to link to: https://va.my.site.com/VAVERA/s/
Michelle noted this system is moving into VA.gov. @xiongjaneg to follow up with CAIA.