-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design: Events: Editors adding email instead of URL in "Call to Action", causing broken link alerts #13329
Comments
Is there a reason this is facilities specific? This seems like a PW thing. |
@swirtSJW Only because it's an Event, otherwise please feel free to pass to PW @jilladams |
Product ownership iis spec'ed out here. |
A note was made in scrum that this card may be for PW instead |
Confirmed - @wesrowe FYI |
@swirtSJW, has the cause been identified or was this the first time you heard of such an issue? @stefaniefgray, this seems like it has probably been causing broken links for a while – is the behavior of adding an email as a CTA not very common? |
@wesrowe This has definitely been an issue for a while and comes up every few weeks or so |
@dsasser, I assigned to you for pre-refinement since it seems like drupal is doing the bad handling here. |
This isn't specific to the Event content type. Anywhere the linkit field widget is in use for a link field, we will experience the same result. I don't have a list on hand presently, but last count we had about 23 instances of this field widget spread across the CMS. The Linkit module contains an "email" matcher that when used will auto-populate the "mailto:" prefix for an email address. See screenshots below. The email matcher isn't in use today, but can easily be added to the default 'profile' here. Additionally, the help text can be enhanced to conditionally show the mailto option by applying the patch from here. One decision point that we need to address: do we want ALL instances of the linkit field to behave the same way? If so, we can apply the email matcher to the existing 'default' linkit profile. Otherwise, we will need to create/clone the existing default profile and add the email matcher there. And finally we would need to set the new profile on any fields we want email matching on. Depending on our response here, will not greatly affect the overall estimate, which I would guess is about a 3. |
Paging @timcosgrove and/or @ndouglas from a CMS Collab POV as FYI / in case you have opinions here. |
I can't think of any reason we'd want to treat some field instances differently, but I might have a blind spot in my reasoning 🙂 IMHO add the matcher to the default profile as you suggested, @dsasser. |
Thanks for this analysis @dsasser. So right now, anywhere an Editor adds an email address as an "external link" in Linkit, across all these 20+ instances, they create a broken experience for a Veteran. Is that right? If so, I don't see how it would do any harm to make it a proper, not-broken mailto link. So my answer to your first decision point is: Let's apply it to every Linkit instance. I think improving the help text sounds like a good idea also. I'll update the ACs and we can review with Dave in a refinement or planning meeting. |
I can't say this with 100% certainty because I haven't made connections from the linkit fields to the requisite frontend templates, but it is very likely. Fortunately it is easier to apply the change to all linkit fields globally than to create one-off profiles. |
From sprint 89 planning:
|
@stefaniefgray, we refined this with the UX team. A couple questions: You said above this happens every couple weeks
|
Hi @wesrowe -- thanks for refining it! Question 1: What do you do when you see a broken link caused by an email address in CTA?
Question 2: If you're asking Editors to correct, do they typically know how they would request RSVPs (or whatever action) using a proper url?
Question 3: Is the link corrected quickly, before it impacts Veterans?
|
Thanks @stefaniefgray – one of the options for improving this situation is to only allow URLs, per the intended design. I.e., add validation to reject email addresses. More questions!
|
@stefaniefgray, just pinging you again on this. @thejordanwood, is there anything else you need to know before starting on this? cc @aklausmeier |
@wesrowe Nothing else from me. I'm ready to start this! |
Wow, I'm sorry @wesrowe -- I typed this and never clicked "Comment" 🤦♀️
|
@wesrowe The design is ready for your review. The mockups can be viewed in the Call to Action tab of this Figma file. @aklausmeier and @laflannery have approved this design. I have a couple of notes on this and what's changing:
|
A gap in our understanding that need FE dev input: We need to know how/if the "registration required" checkbox in the Event UI is used by the FE template. Example:
The Event Editor checked the box for required, but I don't see anything in the FE that indicates that: @chriskim2311 or @randimays, is it a pre-refinement (low-lift) activity to see whether the field from Drupal is being used in the template? If so, please check it out and comment here. Thanks! |
Closing this ticket. A new ticket has been made to find our if the "registration required" checkbox is being used anywhere. |
Aaaand note: the question I asked FE engineers in the comment above is one of the ACs in the new ticket. |
Describe the defect
As an editor on https://prod.cms.va.gov/ creating a new Event, I would like attendees to RSVP by emailing an address such as VANJHCSCommsTeam [at] va.gov.
Unfortunately, if an email address is added as the "Call to Action" URL without the
mailto:
prefix, it saves as/VANJHCSCommsTeam%40va.gov
Note: The help text for adding an Event "Call to Action" URL does not advise editors to add
mailto:
before email addresses.This issue is inconvenient for site visitors who may wish to click the link to RSVP.
This issue also creates broken link alerts that are reported every 30-60 minutes in #content-broken-links until they are resolved by the editor or by a member of the VA Drupal CMS Help Desk team.
Sample broken link alert created by this issue provided in screenshot below.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Email addresses stay true to original formatting when added as an Event "Call to Action" URL without the
mailto:
prefix.Screenshots
Real life example:
From https://prod.cms.va.gov/new-jersey-health-care/events/55340
From #content-broken-links:
Broken link report: https://dsva.slack.com/archives/C030F5WV2TF/p1681777264243279
Additional context
If this issue is declined, the help text for Event "Call to Action" URLs should be updated to reflect that email addresses require the
mailto:
prefix.Suggested ACs from Help Desk
mailto:
Design
Design file in Figma
Design Acceptance Criteria
The text was updated successfully, but these errors were encountered: