-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Events] Provide an FE design to expose the CMS field (registration required checked) to the FE #15388
Comments
assigned to Jordan for pre-finement. |
@wesrowe @thejordanwood The registration required field is available to this template (I checked, and it's coming out |
What I found while spelunking:
From a design standpoint, I can't find an answer to if "registration is required for this event" was intended show on the FE or not. My opinion is that it should show only if the Registration call to action is selected. The other call to actions (Apply and RSVP) imply that a next step is required and the More Details call to action should have no requirements. |
We talked about this briefly in FE refinement, and the next step seems like: let's get a comp together to propose what shoul d happen between CMS <>FE so Editors can tell Veterans to Register. Queing to refine more with UX. |
Rereading I think we are down to:
If there are any events where the box is checked (Drupal could audit and tell us that), that indicates it's true for some events, and we should consider exposing it to the FE, near the CTA. |
@jilladams I do believe that there are some events where this is checked, so we may need to show it on the FE. |
This ticket has been updated to cover providing a FE design to expose that CMS field to the FE. Calling this refined, but if we wind up with more questions during the work or need to add/update ACs, just holler. |
End of sprint update: I added the design to the Outreach and events Sketch file, but haven't had time to get feedback this sprint. I added ACs to the ticket to show who I need to get feedback from. |
After thinking this through more, I believe this will need a change in Drupal to provide a better UX experience.
|
|
I agree with Laura in general that I think the " is required" field uses Registration in a more general sense, where Apply / RSVP/ Registration CTAs are the specific flavors of Registration that may be required. But: we could vet that with Amanda? (Was thinking to myself: ideally we'd have a business owner to verify that with, but Events straddle everything (VEO, VAMCs, Vet Centers, Regional Offices), so need to be abstracted and I don't think anyone but Dave or Amanda could really give us this guidance.) |
@jilladams @aklausmeier @laflannery I now show what this would look like on the FE and in Drupal if we say "Registration/RSVP/Application is required for this event." |
@aklausmeier I missed this one in our review earlier but it's in the same state -- mockup is ready and review requested. @thejordanwood @FranECross and Amanda: FYI that I updated ACs per the new guidance for requesting review, and added a couple Sprint 100 ACs that should close this out once Amanda has time to review. Feel free to update points as needed. |
@thejordanwood I definitely think it makes more sense to break it up like this, so the sentences are more specific. My last comment, and it's more on the nitpicky side is that "RSVP is required for this event" sounds odd to me. Would it sound more natural is we swapped the word order to be "It is required to RSVP for this event"? And if it's easier to have the same structure for all versions it could work for everything (It is required to register/apply/RSVP for this event). So that's my last thought but @aklausmeier might have an idea on this. |
@thejordanwood Drupal design looks good to me. TY for showing each flow. Having the required verbiage stay consistent is the best UX for our editors. For FE design, I'm thinking for better scanability for Veterans, we pop the required verbiage up to the details above and only show when required is selected in Drupal. Quick mockup to show what I'm thinking: |
@aklausmeier I've updated the Sketch file to reflect those changes. The copy will now say:
I want to note that the FE desktop mockups were a bit inaccurate and that social media links will display between the required line and the CTA. I still think this looks good though! @laflannery Feel free to look over again and provide any additional feedback if needed. @FranECross I believe we're ready to create FE and BE tickets for this work. |
Thanks, @thejordanwood ! I'll get the tickets created. 🎉 |
@thejordanwood @jilladams Here are the two tickets! |
@aklausmeier @laflannery Let us know if you have any other notes -- if y'all are in alignment, this ticket is ready to close. |
No more notes from me! |
No additional notes from me |
Description
Needs refining – discovered this issue/defect(?) in #13329. Documented in a comment on 13329, FE engineer may respond do that comment.
User story
AS AN Event Editor
I WANT any selections I make in the drupal UI be reflected in the Veteran-facing product
SO THAT Veterans get complete and accurate information about events.
###Design
Background
We need to know how/if the "registration required" checkbox in the Event UI is used by the FE template. At the moment, it doesn't appear to change anything on the front-end.
Example:
The Event Editor checked the box for required, but I don't see anything in the FE that indicates that:
Engineering notes
field_event_registrationrequired
field_event_registrationrequired
is not used anywhere in the FE.FE code
Analytics considerations
Quality / testing notes
Acceptance criteria (Sprint 98 - 3 points)
Acceptance criteria (Sprint 99 - 3 points)
Acceptance criteria (Sprint 100 - 2 points)
The text was updated successfully, but these errors were encountered: