[CU] July Dependency Updates #405
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,15 +18,15 @@ | |
| "homepage": "https://github.com/department-of-veterans-affairs/va-mobile-library#readme", | ||
| "packageManager": "[email protected]", | ||
| "devDependencies": { | ||
| "@typescript-eslint/eslint-plugin": "^7.17.0", | ||
| "@typescript-eslint/parser": "^7.17.0", | ||
| "eslint": "^8.57.0", | ||
| "eslint-config-prettier": "^9.1.0", | ||
| "eslint-plugin-sort-imports-es6-autofix": "^0.6.0", | ||
| "eslint-plugin-testing-library": "^6.2.2", | ||
| "eslint-plugin-tsdoc": "^0.3.0", | ||
| "prettier": "3.3.3", | ||
| "typescript": "~5.3.3" | ||
| }, | ||
| "resolutions": { | ||
| "@storybook/react-docgen-typescript-plugin": "1.0.6--canary.9.cd77847.0", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| // @ts-nocheck | ||
|
There was a problem hiding this comment. FYI @TimRoe, Had to add this because when I tried testing in the app, I would get the following TS error: There was a problem hiding this comment. Hmmm, that's fine for this ticket but we should figure out something better long term where one doesn't need the config in global.d.ts to not get errors when not even using the component. Perhaps create a ticket just for that nearer the end of Snackbar implementation to figure out the least invasive way to go about it. There was a problem hiding this comment. Yeah, I was implying that this is a temporary fix and assume we'd fix it as part of the implementation. There was a problem hiding this comment. Created ticket to make sure we don't miss this: #412 |
||
| import { ToastOptions } from 'react-native-toast-notifications/lib/typescript/toast' | ||
| import React from 'react' | ||
| import Toast, { ToastType } from 'react-native-toast-notifications' | ||
|
|
@@ -42,14 +43,16 @@ type SnackbarProviderProps = { | |
| * <SnackbarProvider /> | ||
| * </> | ||
| * ``` | ||
| * | ||
| * This config will allow it to be called anywhere including outside React components. | ||
| * | ||
| * The Snackbar remains open indefinitely. App configuration should ensure it is dismissed on navigation. | ||
| */ | ||
| export const SnackbarProvider: React.FC<SnackbarProviderProps> = ( | ||
| { | ||
| // globalSnackbar, | ||
| }, | ||
| ) => { | ||
|
Comment on lines
+51
to
+55
|
||
| return ( | ||
| <Toast | ||
| animationDuration={100} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,8 +30,8 @@ | |
| "homepage": "https://github.com/department-of-veterans-affairs/va-mobile-library#readme", | ||
| "packageManager": "[email protected]", | ||
| "devDependencies": { | ||
| "@department-of-veterans-affairs/css-library": "0.8.5", | ||
| "prettier": "^3.3.3", | ||
| "style-dictionary": "^3.9.2" | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why'd this go
^to~?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to satisfy the following expo warning:
Leaving it as a carat will install
v5.5.4which causes the warning to reappear.