[CU] July Dependency Updates #405

narin · 2024-07-23T18:26:46Z

Description of Change

Updates all available dependencies in our mono repo using yarn upgrade-interactive with the exception of a handful of packages.

style-dictionary and eslint have major version updates with breaking changes that need to be resolved. I've created a separate ticket for them: #404

Storybook related dependencies have been updated to the highest v7 version available since react native is not supported on Storybook 8 yet

The following packages have newer version available, but have been updated to the latest version compatible with expo (51.0.22):

@react-native-async-storage/async-storage
@react-native-community/datetimepicker
@types/react
react-native-svg
react-dom
react-native-gesture-handler
react-native-reanimated
react-native-safe-area-context
react-native-screens
react
typescript

Testing Packages

0.20.4-alpha.1
0.20.4-alpha.2

Screenshots/Video

Storybook iOS

screen-20240723-114108.mp4

Storybook Web

App (iOS)

Simulator.Screen.Recording.-.iPhone.15.-.2024-07-23.at.10.36.18.mp4

App (Android)

Screen_recording_20240723_111334.mp4

Testing

Tested on iOS
Tested on Android
Tested on Web

PR Checklist

Code reviewer validation:

General
- PR is linked to ticket(s)
- PR has changelog label applied if it's to be included in the changelog
- Acceptance criteria:
  - All satisfied or
  - Documented reason for not being performed or
  - Split to separate ticket and ticket is linked by relevant AC(s)
- Above PR sections adequately filled out
- If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
Code
- Tests are included if appropriate (or split to separate ticket)
- New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

Merge main into branch
Merge branch to main
Verify that Check Component Integrations workflow ran successfully
Publish new version after merging

…svg-transformer, storybook, eslint-plugin-deprecate, prettier

…nt compatibile

…tment-of-veterans-affairs/va-mobile-library into chore/378-narin-dependency-updates

narin · 2024-07-23T18:47:39Z

packages/components/src/components/Snackbar/Snackbar.tsx

@@ -1,3 +1,4 @@
+// @ts-nocheck


FYI @TimRoe, Had to add this because when I tried testing in the app, I would get the following TS error:

node_modules/@department-of-veterans-affairs/mobile-component-library/src/components/Snackbar/Snackbar.tsx(57,34): error TS7017: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature. error Command failed with exit code 2.

Hmmm, that's fine for this ticket but we should figure out something better long term where one doesn't need the config in global.d.ts to not get errors when not even using the component. Perhaps create a ticket just for that nearer the end of Snackbar implementation to figure out the least invasive way to go about it.

Yeah, I was implying that this is a temporary fix and assume we'd fix it as part of the implementation.

Created ticket to make sure we don't miss this: #412

narin · 2024-07-23T18:48:22Z

packages/components/.storybook/web/main.ts

@@ -18,6 +18,7 @@ module.exports = {
  },
  core: {
    builder: 'webpack5',
+    disableWhatsNewNotifications: true,


Not related to dependency updates but kept seeing this pop up as I was testing and decided to disable it.

narin · 2024-07-23T19:39:47Z

packages/components/src/components/Snackbar/Snackbar.tsx

+export const SnackbarProvider: React.FC<SnackbarProviderProps> = (
+  {
+    // globalSnackbar,
+  },
+) => {


Autoformatting

TimRoe · 2024-07-23T19:51:47Z

package.json

-    "typescript": "^5.3.3"
+    "eslint-plugin-tsdoc": "^0.3.0",
+    "prettier": "3.3.3",
+    "typescript": "~5.3.3"


Why'd this go ^ to ~?

This is to satisfy the following expo warning:

The following packages should be updated for best compatibility with the installed expo version: [email protected] - expected version: ~5.3.3

Leaving it as a carat will install v5.5.4 which causes the warning to reappear.

TimRoe · 2024-07-24T15:25:16Z

packages/components/package.json

-    "react-i18next": "^14.1.2",
+    "@os-team/i18next-react-native-language-detector": "^1.0.34",
+    "i18next": "^23.12.2",
+    "react-i18next": "^15.0.0",


Probably fine, but may be good to double check use cases in the app if you didn't since this is the package that broke from a minor update recently. So double checking the external link prompt to leave the app and "# of #" screen reading for Segmented control. Good confirmation they didn't do anything breaking with a major increment since they broke things with a minor increment.

Confirmed with voiceover in the app that these translations are still working properly.

TimRoe

Approving with a couple notes in addition to comments:

See a Storybook Web heading, but not any video run through
Probably good to propagate the following info to the ACs on the ticket as well:

style-dictionary and eslint have major version updates with breaking changes that need to be resolved. I've created a separate ticket for them: #404

narin and others added 13 commits July 22, 2024 08:35

babel and storybook minor updates

9c55f6c

Update expo related packages

483a733

Update testing related packages

866c1c8

Update i18next related packages

2ad1349

Update @typescript-eslint deps, prettier, typescript, styled-components

0ffe492

Update babel-plugin-react-native-web, react-native-web, react-native-…

eabd41b

…svg-transformer, storybook, eslint-plugin-deprecate, prettier

Update typescript plugins, expo, eslint, downgrade typescript to esli…

c3d172a

…nt compatibile

Disable whats new notications in storybook web

446fff7

Update @storybook/addon-react-native-web

7356990

Update vads css-library and component-library

77d675c

Version bump: components-v0.20.4-alpha.2

f5cf622

Temporary @ts-nocheck on Snackbar

81620ff

Merge branch 'chore/378-narin-dependency-updates' of github.com:depar…

7880410

…tment-of-veterans-affairs/va-mobile-library into chore/378-narin-dependency-updates

narin changed the title ~~[CU] July Dependency U pdates~~ [CU] July Dependency Updates Jul 23, 2024

narin added the changelog label Jul 23, 2024

narin commented Jul 23, 2024

View reviewed changes

narin marked this pull request as ready for review July 23, 2024 18:48

narin requested a review from a team as a code owner July 23, 2024 18:48

narin commented Jul 23, 2024

View reviewed changes

TimRoe reviewed Jul 23, 2024

View reviewed changes

TimRoe reviewed Jul 24, 2024

View reviewed changes

TimRoe approved these changes Jul 24, 2024

View reviewed changes

va-mobile-automation-robot and others added 2 commits July 25, 2024 17:01

Version bump: components-v0.20.4-alpha.3

b9888a6

Merge branch 'main' into chore/378-narin-dependency-updates

d96b8e1

narin merged commit fd74169 into main Jul 25, 2024
5 of 7 checks passed

narin deleted the chore/378-narin-dependency-updates branch July 25, 2024 17:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CU] July Dependency Updates #405

[CU] July Dependency Updates #405

narin commented Jul 23, 2024 •

edited

Loading

narin Jul 23, 2024

TimRoe Jul 24, 2024

narin Jul 25, 2024

narin Jul 25, 2024

narin Jul 23, 2024

narin Jul 23, 2024

TimRoe Jul 23, 2024

narin Jul 25, 2024

TimRoe Jul 24, 2024

narin Jul 25, 2024

TimRoe left a comment

[CU] July Dependency Updates #405

[CU] July Dependency Updates #405

Conversation

narin commented Jul 23, 2024 • edited Loading

Description of Change

Testing Packages

Screenshots/Video

Storybook iOS

Storybook Web

App (iOS)

App (Android)

Testing

PR Checklist

Publish

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimRoe left a comment

Choose a reason for hiding this comment

narin commented Jul 23, 2024 •

edited

Loading