Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Button border and background color fixes for Secondary variants #36

Merged
merged 8 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
with:
registry-url: https://registry.npmjs.org/
node-version-file: '.nvmrc'
token: ${{ secrets.VA_MOBILE_ROBOT_GITHUB_PAT }}
- run: yarn install
- name: Bump version and publish to NPM
id: bump-version
Expand Down
209 changes: 209 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,209 @@
# Changelog

## [Unreleased](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/HEAD)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.2.0...HEAD)

**Merged pull requests:**

- feature/6870-nr-vabutton [\#34](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/34) ([narin](https://github.com/narin))

## [components-v0.2.0](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.2.0) (2023-11-16)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.15...components-v0.2.0)

## [components-v0.1.1-alpha.15](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.15) (2023-11-16)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.14...components-v0.1.1-alpha.15)

## [components-v0.1.1-alpha.14](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.14) (2023-11-16)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.13...components-v0.1.1-alpha.14)

## [components-v0.1.1-alpha.13](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.13) (2023-11-09)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.12...components-v0.1.1-alpha.13)

## [components-v0.1.1-alpha.12](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.12) (2023-11-09)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.11...components-v0.1.1-alpha.12)

## [components-v0.1.1-alpha.11](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.11) (2023-11-09)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.10...components-v0.1.1-alpha.11)

## [components-v0.1.1-alpha.10](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.10) (2023-11-09)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.9...components-v0.1.1-alpha.10)

## [components-v0.1.1-alpha.9](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.9) (2023-11-09)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.7...components-v0.1.1-alpha.9)

## [components-v0.1.1-alpha.7](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.7) (2023-11-09)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/tokens-v0.2.0...components-v0.1.1-alpha.7)

## [tokens-v0.2.0](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/tokens-v0.2.0) (2023-11-09)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/tokens-v0.1.1-alpha.1...tokens-v0.2.0)

## [tokens-v0.1.1-alpha.1](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/tokens-v0.1.1-alpha.1) (2023-11-09)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.6...tokens-v0.1.1-alpha.1)

## [components-v0.1.1-alpha.6](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.6) (2023-11-09)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/tokens-v0.1.1-alpha.0...components-v0.1.1-alpha.6)

## [tokens-v0.1.1-alpha.0](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/tokens-v0.1.1-alpha.0) (2023-11-09)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.5...tokens-v0.1.1-alpha.0)

**Merged pull requests:**

- CU/6700-roettger-MobileLibraryPRTemplate [\#33](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/33) ([TimRoe](https://github.com/TimRoe))

## [components-v0.1.1-alpha.5](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.5) (2023-11-08)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.4...components-v0.1.1-alpha.5)

**Merged pull requests:**

- 6857-roettger-FixRNWebDeprecatedAttribsOnSegmentedControl [\#32](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/32) ([TimRoe](https://github.com/TimRoe))
- 6989-roettger storybook missing dist folder locally [\#31](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/31) ([TimRoe](https://github.com/TimRoe))

## [components-v0.1.1-alpha.4](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.4) (2023-11-08)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.3...components-v0.1.1-alpha.4)

## [components-v0.1.1-alpha.3](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.3) (2023-11-08)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.2...components-v0.1.1-alpha.3)

## [components-v0.1.1-alpha.2](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.2) (2023-11-08)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.1...components-v0.1.1-alpha.2)

## [components-v0.1.1-alpha.1](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.1) (2023-11-08)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.1.1-alpha.0...components-v0.1.1-alpha.1)

## [components-v0.1.1-alpha.0](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.1.1-alpha.0) (2023-11-08)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/tokens-v0.1.0...components-v0.1.1-alpha.0)

## [tokens-v0.1.0](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/tokens-v0.1.0) (2023-11-08)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/tokens-v0.0.13-alpha.3...tokens-v0.1.0)

## [tokens-v0.0.13-alpha.3](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/tokens-v0.0.13-alpha.3) (2023-11-08)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/tokens-v0.0.13-alpha.2...tokens-v0.0.13-alpha.3)

## [tokens-v0.0.13-alpha.2](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/tokens-v0.0.13-alpha.2) (2023-11-08)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/tokens-v0.0.13-alpha.0...tokens-v0.0.13-alpha.2)

## [tokens-v0.0.13-alpha.0](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/tokens-v0.0.13-alpha.0) (2023-11-08)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/tokens-v0.0.12...tokens-v0.0.13-alpha.0)

**Merged pull requests:**

- Bump browserify-sign from 4.2.1 to 4.2.2 [\#30](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/30) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump browserify-sign from 4.2.1 to 4.2.2 in /packages/components [\#29](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/29) ([dependabot[bot]](https://github.com/apps/dependabot))
- GHA Release Workflow [\#28](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/28) ([narin](https://github.com/narin))
- Bump @babel/traverse from 7.22.8 to 7.23.2 [\#27](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/27) ([dependabot[bot]](https://github.com/apps/dependabot))

## [tokens-v0.0.12](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/tokens-v0.0.12) (2023-10-27)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.31...tokens-v0.0.12)

## [components-v0.0.31](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.31) (2023-10-27)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/tokens-v0.0.11-alpha.0...components-v0.0.31)

## [tokens-v0.0.11-alpha.0](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/tokens-v0.0.11-alpha.0) (2023-10-26)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.31-alpha.2...tokens-v0.0.11-alpha.0)

## [components-v0.0.31-alpha.2](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.31-alpha.2) (2023-10-26)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.31-alpha.1...components-v0.0.31-alpha.2)

## [components-v0.0.31-alpha.1](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.31-alpha.1) (2023-10-26)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.31-alpha.0...components-v0.0.31-alpha.1)

## [components-v0.0.31-alpha.0](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.31-alpha.0) (2023-10-26)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.30...components-v0.0.31-alpha.0)

## [components-v0.0.30](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.30) (2023-10-26)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.29...components-v0.0.30)

## [components-v0.0.29](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.29) (2023-10-26)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.28...components-v0.0.29)

## [components-v0.0.28](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.28) (2023-10-26)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.27...components-v0.0.28)

## [components-v0.0.27](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.27) (2023-10-26)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.27-beta.1...components-v0.0.27)

## [components-v0.0.27-beta.1](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.27-beta.1) (2023-10-26)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.27-beta.0...components-v0.0.27-beta.1)

## [components-v0.0.27-beta.0](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.27-beta.0) (2023-10-25)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.27-alpha.0...components-v0.0.27-beta.0)

## [components-v0.0.27-alpha.0](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.27-alpha.0) (2023-10-25)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/components-v0.0.26...components-v0.0.27-alpha.0)

## [components-v0.0.26](https://github.com/department-of-veterans-affairs/va-mobile-library/tree/components-v0.0.26) (2023-10-25)

[Full Changelog](https://github.com/department-of-veterans-affairs/va-mobile-library/compare/bfe7f18051ff4723b5e7085061f9b2749690d10d...components-v0.0.26)

**Closed issues:**

- Error: GitHub Repository Not Mapped To eMASS System [\#5](https://github.com/department-of-veterans-affairs/va-mobile-library/issues/5)
- Error: GitHub Repository Not Mapped To eMASS System [\#4](https://github.com/department-of-veterans-affairs/va-mobile-library/issues/4)

**Merged pull requests:**

- Bump @babel/traverse from 7.22.8 to 7.23.2 in /packages/components [\#26](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/26) ([dependabot[bot]](https://github.com/apps/dependabot))
- 6826 roettger segmented control storybook updates [\#25](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/25) ([TimRoe](https://github.com/TimRoe))
- Added CI check to require checkboxes be complete [\#24](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/24) ([timwright12](https://github.com/timwright12))
- Fix Storybook on Android [\#23](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/23) ([narin](https://github.com/narin))
- 6507 roettger add segmented control unit tests [\#22](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/22) ([TimRoe](https://github.com/TimRoe))
- Chore/6692 add nvm [\#21](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/21) ([timwright12](https://github.com/timwright12))
- Adding workflow to run checks against the VA Mobile App [\#20](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/20) ([timwright12](https://github.com/timwright12))
- Add testIDs prop to SegmentedControl [\#19](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/19) ([narin](https://github.com/narin))
- Add style-dictionary and generate initial tokens [\#18](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/18) ([narin](https://github.com/narin))
- Fix Storybook web [\#17](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/17) ([narin](https://github.com/narin))
- Updated repo name assets [\#16](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/16) ([timwright12](https://github.com/timwright12))
- Adding Storybook publishing workflow [\#15](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/15) ([timwright12](https://github.com/timwright12))
- 6407-roettger-implementSegmentedControlToApp [\#14](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/14) ([TimRoe](https://github.com/TimRoe))
- Automate Linting [\#13](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/13) ([narin](https://github.com/narin))
- Adding npm publish workflow [\#12](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/12) ([timwright12](https://github.com/timwright12))
- Storybook Docs template [\#11](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/11) ([narin](https://github.com/narin))
- 6509-roettger-segmentedControlStorybook [\#10](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/10) ([TimRoe](https://github.com/TimRoe))
- Added npm publish commands [\#9](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/9) ([timwright12](https://github.com/timwright12))
- 6353-roettger-CreateSegmentedControl [\#8](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/8) ([TimRoe](https://github.com/TimRoe))
- Figma Integration [\#7](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/7) ([narin](https://github.com/narin))
- Storybook Initial Setup [\#6](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/6) ([narin](https://github.com/narin))
- Action Required: Configure CodeQL [\#3](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/3) ([veterans-affairs-code-scanning](https://github.com/veterans-affairs-code-scanning))
- 6266-roettger-repoFoundationalStructure [\#2](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/2) ([TimRoe](https://github.com/TimRoe))
- Components automated tests [\#1](https://github.com/department-of-veterans-affairs/va-mobile-library/pull/1) ([narin](https://github.com/narin))



\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
2 changes: 1 addition & 1 deletion packages/components/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@department-of-veterans-affairs/mobile-component-library",
"version": "0.2.0",
"version": "0.2.1",
"description": "VA Design System Mobile Component Library",
"main": "src/index.tsx",
"scripts": {
Expand Down
32 changes: 16 additions & 16 deletions packages/components/src/components/Button/Button.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const meta: Meta<ButtonProps> = {
docs: generateDocs({
name: 'Button',
docUrl:
'https://department-of-veterans-affairs.github.io/va-mobile-app/docs/Flagship%20design%20library/Components/Buttons%20and%20Links/VAButton/',
'https://department-of-veterans-affairs.github.io/va-mobile-app/design/Components/Buttons%20and%20links/Button',
}),
},
decorators: [
Expand All @@ -38,56 +38,56 @@ export default meta

type Story = StoryObj<ButtonProps>

export const Base: Story = {
storyName: 'Base',
export const _Primary: Story = {
storyName: 'Primary',
args: {
buttonType: ButtonVariants.Base,
label: 'Button text',
a11yLabel: 'Alternate a11y text',
a11yHint: 'Descriptive text about this Button',
},
}

export const BaseSecondary: Story = {
storyName: 'Base Secondary',
export const __Secondary: Story = {
storyName: 'Secondary',
args: {
buttonType: ButtonVariants.BaseSecondary,
buttonType: ButtonVariants.Secondary,
label: 'Button text',
a11yLabel: 'Alternate a11y text',
a11yHint: 'Descriptive text about this Button',
},
}

export const Destructive: Story = {
storyName: 'Destructive',
export const ___Base: Story = {
storyName: 'Base Primary',
args: {
buttonType: ButtonVariants.Destructive,
buttonType: ButtonVariants.Base,
label: 'Button text',
a11yLabel: 'Alternate a11y text',
a11yHint: 'Descriptive text about this Button',
},
}

export const Primary: Story = {
storyName: 'Primary',
export const ____BaseSecondary: Story = {
storyName: 'Base Secondary',
args: {
buttonType: ButtonVariants.BaseSecondary,
label: 'Button text',
a11yLabel: 'Alternate a11y text',
a11yHint: 'Descriptive text about this Button',
},
}

export const Secondary: Story = {
storyName: 'Secondary',
export const _____Destructive: Story = {
storyName: 'Destructive',
args: {
buttonType: ButtonVariants.Secondary,
buttonType: ButtonVariants.Destructive,
label: 'Button text',
a11yLabel: 'Alternate a11y text',
a11yHint: 'Descriptive text about this Button',
},
}

export const White: Story = {
export const ______White: Story = {
storyName: 'White',
args: {
buttonType: ButtonVariants.White,
Expand Down
Loading
Loading