-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Button border and background color fixes for Secondary variants #36
Conversation
@@ -72,17 +72,15 @@ export const Button: React.FC<ButtonProps> = ({ | |||
} | |||
break | |||
case ButtonVariants.BaseSecondary: | |||
bgColor = DesignTokens.colorWhite | |||
bgColorPressed = DesignTokens.colorWhite | |||
bgColor = 'transparent' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a 'transparent' token?
@jessicawoodin thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Figma, we wouldn't use a design token for this, so I'm leaning towards not creating one here either. In Figma, if we wanted to make something transparent, we just wouldn't apply a "fill color" to that layer which seems consistent with how it's being done here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Did discover and created a bug poking at it in Web Storybook, but it appeared not directly related to this ticket (as it is also broken on the published Storybook).
…f-veterans-affairs/va-mobile-library into bug/7330-narin-button-fixes
Ticket department-of-veterans-affairs/va-mobile-app#7330
Description of Change
Testing Packages
Screenshots/Video
Testing
PR Checklist
Code reviewer validation:
Publish
If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:
main
into branchmain