Add testIDs prop to SegmentedControl #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Should this also include a PR on the app side consuming publishing of these changes? |
timwright12
approved these changes
Sep 28, 2023
If this is something they need right now, sure, but we can also work that out in whatever release plan we haven't made yet |
|
Added typescript typings to the style-dictionary that are also generated to the Also created PR to bump mobile-components version: department-of-veterans-affairs/va-mobile-app#6886 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testIDsas an optional prop to the SegmentedControl componenttestIDsis a string of arrays that can be passed and assigned to each segment based on indexLinked issue: department-of-veterans-affairs/va-mobile-app#6732
Screenshots
iOS
Web