Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Add testID option to segmented control component #6732

Closed
5 tasks
rbontrager opened this issue Sep 13, 2023 · 4 comments
Closed
5 tasks

BUG - Add testID option to segmented control component #6732

rbontrager opened this issue Sep 13, 2023 · 4 comments
Assignees
Labels
bug Used to identify a bug ticket that will be worked through the bug process front-end Ticket requires front-end work mobile-platform work associated with building & maintaining the VA Mobile Platform

Comments

@rbontrager
Copy link
Contributor

What happened?

Some of our detox tests are currently failing because the tests were looking for a id from the old testID function. This was cleaned up and removed when the segment control component was made. While we can change the tests to look for the text for now it would be nice to have a testID option added back in so we don't have any flakiness in the future.

Specs:

  • Device:
  • OS:
  • User Account:
  • Accessibility State:

Steps to Reproduce

Desired behavior

Acceptance Criteria

Bug Severity - BE SURE TO ADD THE SEVERITY LABEL

See Bug Tracking for details on severity levels

  • Impact: High Low
  • Frequency: High Low
  • 3 - Low
  • 2 - High
  • 1 - Critical

Linked to Story

Screen shot(s) and additional information

Full JSON response for services related to issue (expand/collapse)

Ticket Checklist

  • Steps to reproduce are defined
  • Desired behavior is added
  • Labels added (front-end, back-end, relevant feature, accessibility, etc)
  • Estimate of 1 added (for front-end tickets)
  • Added either to the relevant feature epic (if found during new feature implementation), or the bug epic
@rbontrager rbontrager added bug Used to identify a bug ticket that will be worked through the bug process mobile-platform work associated with building & maintaining the VA Mobile Platform labels Sep 13, 2023
@kellylein kellylein added the front-end Ticket requires front-end work label Sep 21, 2023
@narin narin self-assigned this Sep 27, 2023
@narin
Copy link
Contributor

narin commented Sep 28, 2023

@narin
Copy link
Contributor

narin commented Oct 2, 2023

Code is complete and merged in MoVADS repo. Waiting on va-mobile-app PR review to bump the version on the app: #6886

@rbontrager rbontrager self-assigned this Oct 3, 2023
@narin
Copy link
Contributor

narin commented Oct 3, 2023

@rbontrager Can we consider this ticket complete, or were you expecting for testIDs to be added to each existing SegmentedControl as part of this work?

@rbontrager
Copy link
Contributor Author

Verified that testIDs have been added to segmented control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to identify a bug ticket that will be worked through the bug process front-end Ticket requires front-end work mobile-platform work associated with building & maintaining the VA Mobile Platform
Projects
None yet
Development

No branches or pull requests

3 participants