Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2096 - Remove approval to production step in CD pipeline #2117

Merged
merged 1 commit into from
Nov 12, 2024
Merged

#2096 - Remove approval to production step in CD pipeline #2117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions .github/workflows/cd-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,17 @@ jobs:
ref: ${{ needs.create-and-post-tag.outputs.newVersion }}
lambdaDeploy: true

approval-deploy-staging:
approval-deploy:
coreycarvalho marked this conversation as resolved.
Show resolved Hide resolved
needs: deploy-to-perf
environment:
name: staging-deploy
runs-on: ubuntu-latest
steps:
- name: Pause for manual approval
run: echo "Deployment paused for manual approval."
run: echo "Deployment paused for manual approval to staging and production."

create-release-notes:
needs: [create-and-post-tag, approval-deploy-staging]
needs: [create-and-post-tag, approval-deploy]
uses: ./.github/workflows/create-release-notes.yml
secrets: inherit
with:
Expand All @@ -101,17 +101,8 @@ jobs:
ref: ${{ needs.create-and-post-tag.outputs.newVersion }}
lambdaDeploy: true

approval-deploy-prod:
needs: deploy-to-staging
environment:
name: prod-deploy
runs-on: ubuntu-latest
steps:
- name: Pause for manual approval
run: echo "Pipeline paused for pending approval of staging by QA"

publish-release-notes:
needs: [create-release-notes, approval-deploy-prod]
needs: [create-release-notes, deploy-to-staging]
uses: ./.github/workflows/publish-release-notes.yml
secrets: inherit
with:
Expand Down