Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2096 - Remove approval to production step in CD pipeline #2117

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

coreycarvalho
Copy link

@coreycarvalho coreycarvalho commented Nov 12, 2024

Description

This PR removes the approval to production step in our CD pipeline. With anomaly detection in place, we have reached a point where we feel comfortable automating our CD process to production.

issue #2086

How Has This Been Tested?

It's difficult to test this since this is a change to a production step in our CD process. There isn't a lower environment to test this in. I'm confident that this will work, as it is just removing one step.

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@coreycarvalho coreycarvalho self-assigned this Nov 12, 2024
@coreycarvalho coreycarvalho changed the title Remove approval to production step in CD pipeline #2096 - Remove approval to production step in CD pipeline Nov 12, 2024
@coreycarvalho coreycarvalho marked this pull request as ready for review November 12, 2024 17:24
@coreycarvalho coreycarvalho requested a review from a team as a code owner November 12, 2024 17:24
@coreycarvalho coreycarvalho merged commit a7a340b into main Nov 12, 2024
13 checks passed
@coreycarvalho coreycarvalho deleted the 2086-remove-approval-prod branch November 12, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants