-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VA-16652] Align Main mental health phone number with service contact info #1907
Conversation
9b100b5
to
8e05d22
Compare
8e05d22
to
ab662fa
Compare
ab662fa
to
992fd59
Compare
I'm tagging @laflannery for review here for the aria fix. |
224ef77
to
9a79f3d
Compare
e89e1ed
to
6b056db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Some of these were handled in the VAMC and VBA merger of service location and a lot of service location is changing in the integration branch.
I think this should go into that branch VACMS-16144-VAMC-ServiceLocationParagraphs
@eselkin For merging this pull request into |
@maxx1128 We can put this in main, but either way work will probably have to be redone somewhere. You might have to help me fix the other branch when I pull in the new changes from main. |
Summary
If the facility's mental health care chooses "Use the general facility phone number," it will show the facility's mental health care number, not their main phone number. It also updates the phone number partial being used so it includes
aria-describedby
with the label.Related issue(s)
Align Main mental health phone number with service contact info va.gov-cms#16652
Testing done
Visual. Checked all available services on Hot Springs VA Medical Center and Cheyenne VA Medical Center in my tugboat instance.
Screenshots
Note: this screenshots include changes that are no longer included in this pull request. The only ones relevant to this pull request are the main phone numbers.
Before
After
What areas of the site does it impact?
VA Health Care Facilities
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websites
Slack channel for questionsRequested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?