VA-16652: separate phone extension for mental health numbers

[maxx1128]

Summary

A pull request for using VBA facility mental health numbers in the mental health service accordions was recently merged. However, the phone number component needs to have the phone number's extension separated from the number for it to display correctly.

Related issue(s)

• Link to ticket created in va.gov-cms repo
  Align Main mental health phone number with service contact info va.gov-cms#16652

Testing done

Locally, on tugboat build.

See the services at the Hot Springs VA Medical Center (no mental health phone number extension) and the Fayetteville VA Medical Center (has mental health phone number extension)

Screenshots

Data from the filter that confirms the extension is separated from the phone number as expected:

The mental health phone number showing properly in the accordion.

What areas of the site does it impact?

VBA Regional Facility pages, specifically only the main numbers for each service.

Acceptance criteria

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

[eselkin]

Looks good to me. I wonder if we should be checking this on all numbers and not just this type of number.

[eselkin]

LGTM. I thought I reviewed with approval.

[jilladams]

(@maxx1128 Agree with Eli that a spot check of other phone numbers would be wise, given our spaghetti pile of components / templates, to make sure our impact to VAMCs is known / understood.)

[va-vfs-bot]

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

[va-vfs-bot]

Icon found

Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.

What you can do

Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.