Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-notification: mark component for deprecation #941

Merged
merged 2 commits into from
Nov 9, 2023
Merged

va-notification: mark component for deprecation #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c787e75
Deprecating va-notification in storybook
Andrew565 Nov 9, 2023
074265d
Version bump
Andrew565 Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/storybook/stories/va-notification.stories.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { getWebComponentDocs, propStructure, StoryDocs } from './wc-helpers';
const notificationDocs = getWebComponentDocs('va-notification');

export default {
title: 'Components/Notification',
title: 'Deprecated/Notification',
id: 'components/va-notification',
argTypes: {
argTypes: {
children: {
table: {
disable: true,
Expand Down
2 changes: 1 addition & 1 deletion packages/web-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@department-of-veterans-affairs/web-components",
"version": "4.47.0",
"version": "4.47.1",
"description": "Stencil Component Starter",
"main": "dist/index.cjs.js",
"module": "dist/index.js",
Expand Down
12 changes: 6 additions & 6 deletions packages/web-components/src/components/va-notification/va-notification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@ import {
Element,
Event,
EventEmitter,
Host,
Prop,
Host,
Prop,
h,
Listen,
} from '@stencil/core';
import classnames from 'classnames';

/**
* @componentName Notification
* @maturityCategory caution
* @maturityLevel proposed
* @maturityCategory dont_use
* @maturityLevel deprecated
*/

@Component({
Expand Down Expand Up @@ -84,7 +84,7 @@ export class VaNotification {
* If `true`, the component-library-analytics event is disabled.
*/
@Prop() disableAnalytics?: boolean = false;

/**
* Fires when the component is closed by clicking on the close icon. This fires only
* when closeable is true.
Expand All @@ -106,7 +106,7 @@ export class VaNotification {
componentLibraryAnalytics: EventEmitter;

/**
* Listen for the va-link GA event and capture it so
* Listen for the va-link GA event and capture it so
* that we can emit a single va-notification GA event that includes
* the va-link details.
*/
Expand Down
Loading