Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

va-notification: mark component for deprecation #941

Merged
merged 2 commits into from
Nov 9, 2023
Merged

va-notification: mark component for deprecation #941

merged 2 commits into from
Nov 9, 2023

Conversation

Andrew565
Copy link
Contributor

@Andrew565 Andrew565 commented Nov 9, 2023 •
edited by github-actions bot
Loading

Chromatic

https://2248-deprecate-notification-component--60f9b557105290003b387cd5.chromatic.com

Description

Closes #2248

Testing done

Tested locally using Storybook and Brave

Screenshots

Screenshot 2023-11-09 at 12 21 57 PM

Acceptance criteria

  • Component shows as "Deprecated - Do Not Use" in storybook

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@Andrew565 Andrew565 added the patch Patch change in semantic versioning label Nov 9, 2023
@Andrew565 Andrew565 self-assigned this Nov 9, 2023
@Andrew565 Andrew565 requested a review from a team as a code owner November 9, 2023 19:39
jamigibbs
jamigibbs approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@jamigibbs jamigibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Andrew565 Andrew565 merged commit adfd13f into main Nov 9, 2023
8 checks passed
@Andrew565 Andrew565 deleted the 2248-deprecate-notification-component branch November 9, 2023 20:11
@jamigibbs jamigibbs changed the title 2248 - Deprecating va-notification in storybook va-notification: mark component for deprecation Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamigibbs jamigibbs jamigibbs approved these changes

Assignees

@Andrew565 Andrew565

Labels
patch Patch change in semantic versioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Notification component
2 participants
@Andrew565 @jamigibbs