Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert deprecated React components from previous release #913

Merged
merged 6 commits into from
Oct 17, 2023

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Oct 17, 2023

Chromatic

https://revert-deprecated-react--60f9b557105290003b387cd5.chromatic.com

Description

Reverting the following commits in an attempt to get our vets-website release PR to pass:

Testing done

Locally with Storybook

Screenshots

N/A

Acceptance criteria

  • [ ]

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

This reverts commit aa1ad59.

# Conflicts:
#	packages/react-components/package.json
This reverts commit 76883c1.

# Conflicts:
#	packages/design-system-dashboard-cli/coverage/lcov-report/write-react-owners-to-csv.js.html
#	packages/react-components/package.json
…902)"

This reverts commit 1dc8b7e.

# Conflicts:
#	packages/design-system-dashboard-cli/coverage/lcov-report/write-react-owners-to-csv.js.html
@jamigibbs jamigibbs added the major Major change in semantic versioning label Oct 17, 2023
guidanceName: 'OMB info',
maturityCategory: DONT_USE,
maturityLevel: DEPRECATED,
},
Copy link
Contributor Author

@jamigibbs jamigibbs Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am intentionally keeping these components removed from Storybook so that they at least won't appear in the public facing documentation.

@@ -1,7 +1,7 @@
{
"name": "@department-of-veterans-affairs/component-library",
"description": "VA.gov component library. Includes React and web components.",
"version": "25.0.0",
"version": "26.0.0",
Copy link
Contributor Author

@jamigibbs jamigibbs Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating core because I will be creating a release after it is merged.

@jamigibbs jamigibbs changed the title Revert deprecated React components from previous relesae Revert deprecated React components from previous release Oct 17, 2023
@jamigibbs jamigibbs marked this pull request as ready for review October 17, 2023 16:35
@jamigibbs jamigibbs requested a review from a team as a code owner October 17, 2023 16:35
Copy link
Contributor

@it-harrison it-harrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants