OMBInfo: Remove deprecated React component #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 526f078.
jamigibbs
commented
Oct 18, 2023
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@department-of-veterans-affairs/component-library", | |||
| "description": "VA.gov component library. Includes React and web components.", | |||
| "version": "26.0.0", | |||
| "version": "27.0.0", | |||
There was a problem hiding this comment.
updating core version because we will be creating a release after this PR is merged
it-harrison
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://remove-ombinfo-react--60f9b557105290003b387cd5.chromatic.com
Description
This reverts commit 526f078.
We needed to add back the deprecated components in order to get the vets-website component release to merge. Now that the release has been merged, we will start removing those components again starting with OMBInfo:
Testing done
local build
Screenshots
N/A
Acceptance criteria
Definition of done