-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlertBox and MaintenanceBanner: remove deprecated components #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powellkerry
approved these changes
Oct 11, 2023
it-harrison
changed the title
Remove AlertBox and MaintenanceBanner
AlertBox and MaintenanceBanner: remove deprecated components
Oct 11, 2023
2 tasks
2 tasks
jamigibbs
added a commit
that referenced
this pull request
Oct 19, 2023
) * Revert "Revert "AlertBox and MaintenanceBanner: remove deprecated components (#902)"" * remove MaintenanceBanner imports * update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://depr-1917--60f9b557105290003b387cd5.chromatic.com
Description
This PR removes the deprecated AlertBox component from the repo. It also removes MaintenanceBanner React component because it uses the AlertBox component; the sole usage of MaintenanceBanner has been replaced/merged in vets-website.
Closes department-of-veterans-affairs/vets-design-system-documentation#1917
Testing done
local testing
Screenshots
n/a
Acceptance criteria
Definition of done