Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlertBox and MaintenanceBanner: remove deprecated components #902

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

it-harrison
Copy link
Contributor

@it-harrison it-harrison commented Oct 11, 2023

Chromatic

https://depr-1917--60f9b557105290003b387cd5.chromatic.com


Description

This PR removes the deprecated AlertBox component from the repo. It also removes MaintenanceBanner React component because it uses the AlertBox component; the sole usage of MaintenanceBanner has been replaced/merged in vets-website.

Closes department-of-veterans-affairs/vets-design-system-documentation#1917

Testing done

local testing

Screenshots

n/a

Acceptance criteria

  • [ ]

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@it-harrison it-harrison added the major Major change in semantic versioning label Oct 11, 2023
@it-harrison it-harrison changed the title remove files/refs Remove AlertBox and MaintenanceBanner Oct 11, 2023
@it-harrison it-harrison marked this pull request as ready for review October 11, 2023 19:54
@it-harrison it-harrison requested a review from a team as a code owner October 11, 2023 19:54
@it-harrison it-harrison changed the title Remove AlertBox and MaintenanceBanner AlertBox and MaintenanceBanner: remove deprecated components Oct 11, 2023
@it-harrison it-harrison merged commit 1dc8b7e into main Oct 11, 2023
6 checks passed
@it-harrison it-harrison deleted the depr-1917 branch October 11, 2023 20:13
jamigibbs added a commit that referenced this pull request Oct 17, 2023
…902)"

This reverts commit 1dc8b7e.

# Conflicts:
#	packages/design-system-dashboard-cli/coverage/lcov-report/write-react-owners-to-csv.js.html
jamigibbs added a commit that referenced this pull request Oct 17, 2023
* Revert "Remove LoadingIndicator React component (#879)"

* Revert "OMBInfo: remove React component (#854)"

* Revert "Remove Checkbox React component (#882)"

* Revert "AlertBox and MaintenanceBanner: remove deprecated components (#902)"

* Remove components from Storybook

* update versions
jamigibbs added a commit that referenced this pull request Oct 18, 2023
jamigibbs added a commit that referenced this pull request Oct 19, 2023
)

* Revert "Revert "AlertBox and MaintenanceBanner: remove deprecated components (#902)""

* remove MaintenanceBanner imports

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation - Alert Box
2 participants