Remove LoadingIndicator React component #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamigibbs
reviewed
Oct 12, 2023
There was a problem hiding this comment.
Thanks Ray! A couple of PR house keeping things:
- Zenhub links are disallowed. Can you update your description to use the github issue link instead?
- Update the name of the PR so that it is more appropriate for release notes. ie. Remove deprecated LoadingIndicator React component.
rmessina1010
changed the title
jamigibbs
approved these changes
Oct 12, 2023
jamigibbs
added a commit
that referenced
this pull request
Oct 17, 2023
This reverts commit 69b9985.
2 tasks
jamigibbs
added a commit
that referenced
this pull request
Oct 18, 2023
This reverts commit 2caa4c2. # Conflicts: # packages/design-system-dashboard-cli/coverage/lcov-report/write-react-owners-to-csv.js.html # packages/react-components/index.js # packages/react-components/package.json # packages/react-components/src/index.js
2 tasks
jamigibbs
added a commit
that referenced
this pull request
Oct 19, 2023
* Revert "Revert "Remove LoadingIndicator React component (#879)"" * remove imports * add back to coverage script for failing node test * update version * remove from coverage script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://rm-remove-loading-ind-phase3--60f9b557105290003b387cd5.chromatic.com
Description
Closes 1918
Removes React Loading indicator component
Testing done
Screenshots
N/A
Acceptance criteria
Definition of done