Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaf 4209 - Revert some changes related to the Group API subsystem #2272

Merged
merged 105 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
105 commits
Select commit Hold shift + click to select a range
011d48e
don't run invalid queries
mgaoVA Oct 27, 2023
d582844
LEAF 2285 initial grid multiselect dropd, update repetitive row logic
aerinkayne Nov 1, 2023
c7f0834
LEAF 2285 mv controls template and data value cell search to methods,…
aerinkayne Nov 1, 2023
04c3f7b
implement fulltext search
mgaoVA Nov 2, 2023
2345899
should be safe?
mgaoVA Nov 2, 2023
82b7455
mask wildcards when they're implicit
mgaoVA Nov 2, 2023
6dacb9e
update search syntax
mgaoVA Nov 2, 2023
9f950e0
optimize fulltext search
mgaoVA Nov 2, 2023
a3067fe
fix negative search
mgaoVA Nov 2, 2023
ecca09c
LEAF 2285 gridInput cleanup
aerinkayne Nov 2, 2023
b0b4b25
update defaults, resolve employee prefill issue
mgaoVA Nov 2, 2023
5e00613
remove unused
mgaoVA Nov 2, 2023
b38813e
improve defaults
mgaoVA Nov 2, 2023
be63bb9
LEAF 4111 fix non unique id, rename some variables, template cleanup
aerinkayne Nov 3, 2023
6705b15
Merge branch 'feature/LEAF-2285/grid_format_multiselect_dropdown' int…
aerinkayne Nov 3, 2023
fcba798
update ux
mgaoVA Nov 3, 2023
6eebdf7
LEAF 4111 style fix, rm unused multiselect change, add method comments
aerinkayne Nov 3, 2023
f20a49f
optimize group designated hotspot
mgaoVA Nov 4, 2023
ffa4103
update default and add comment
mgaoVA Nov 5, 2023
1091bc2
LEAF 4111 adjust opt addition, add check for null value
aerinkayne Nov 6, 2023
fa3c5ad
Leaf 4084 - custom emails added to subordinate
Nov 6, 2023
568a2ca
Leaf 4084 - PR comments addressed
Nov 7, 2023
89927be
LEAF 3188 initial updates for upload formats
aerinkayne Nov 7, 2023
f013c58
LEAF 3188 mv method, adjust loading indicator
aerinkayne Nov 8, 2023
484de40
Leaf 4116 - Find a string
Nov 8, 2023
ad8e623
Leaf 4084 - Directory exist
Nov 8, 2023
ffaf673
fix type check issue, allow files to be embedded
mgaoVA Nov 8, 2023
a8b7783
LEAF 3188 add aria attr
aerinkayne Nov 8, 2023
56b95b2
LEAF research - hideshow remaining formats excluding raw_data
aerinkayne Nov 9, 2023
ed0e730
Leaf 4084 - PR comments updated
Nov 13, 2023
7b016a0
Leaf 4130 - Script to replace text
Nov 13, 2023
38cc8dd
Merge pull request #2225 from department-of-veterans-affairs/rc/2023-…
Pelentan Nov 14, 2023
22db4bd
Merge pull request #2222 from department-of-veterans-affairs/optimize…
Pelentan Nov 14, 2023
7c8721a
Merge pull request #2220 from department-of-veterans-affairs/programm…
Pelentan Nov 14, 2023
32211e0
Merge pull request #2219 from department-of-veterans-affairs/fulltext…
Pelentan Nov 14, 2023
1515b6f
Merge pull request #2217 from department-of-veterans-affairs/update-f…
Pelentan Nov 14, 2023
95123c2
Merge pull request #2216 from department-of-veterans-affairs/check-be…
Pelentan Nov 14, 2023
008e2b7
thanks CodeQL
mgaoVA Nov 14, 2023
bd0ea3c
Merge pull request #2228 from department-of-veterans-affairs/inlined-…
Pelentan Nov 14, 2023
e99e8f0
LEAF 2569 add status msg for some date filters. minor 508 fixes
aerinkayne Nov 14, 2023
2c14821
LEAF 4136 updates from master
aerinkayne Nov 14, 2023
2beeabb
LEAF 4136 vue side child formats, fix margin issue
aerinkayne Nov 14, 2023
f3b320b
LEAF 2569 update verbiage and mv conditional status message
aerinkayne Nov 14, 2023
0bd832e
LEAF 2569 rm old arg
aerinkayne Nov 14, 2023
e78a768
Merge pull request #2232 from department-of-veterans-affairs/fix-repl…
Pelentan Nov 14, 2023
77b025f
LEAF 4139 update keypress listeners in orgform
aerinkayne Nov 14, 2023
e4930ed
LEAF 4139 fix jq err from deprecated size method
aerinkayne Nov 14, 2023
8331343
LEAF 2747 add info about custom email notifcations to email template …
aerinkayne Nov 15, 2023
5c2fc66
LEAF-4141: Color Scheme for Organize by Roles
pete-nerantzinis Nov 15, 2023
a4f4bd3
Merge pull request #2237 from department-of-veterans-affairs/bug/LEAF…
Pelentan Nov 15, 2023
fc7574c
typo fix
raphaelfretter Nov 15, 2023
6493218
LEAF 3971 clean up event dispatch and make cond editor modifications
aerinkayne Nov 15, 2023
d23ec55
LEAF 3971 fix spacing
aerinkayne Nov 15, 2023
067f179
Leaf 4084 - PR comments addressed
Nov 15, 2023
28ea717
Merge branch 'master' into feature/Leaf-4084/add_email_and_events_to_…
Nov 16, 2023
61a6345
case insensitive userid
mgaoVA Nov 17, 2023
d402b23
LEAF 4139 find alt solution for chosen dropbox behavior
aerinkayne Nov 18, 2023
a094199
avoid race condition
mgaoVA Nov 20, 2023
9629415
Merge pull request #2242 from department-of-veterans-affairs/avoid-ra…
Pelentan Nov 21, 2023
10bac9e
Merge pull request #2231 from department-of-veterans-affairs/rc/2023-…
Pelentan Nov 21, 2023
fe27570
Merge pull request #2241 from department-of-veterans-affairs/case-ins…
Pelentan Nov 21, 2023
d9fd334
Merge pull request #2239 from department-of-veterans-affairs/enhance/…
Pelentan Nov 21, 2023
0437298
Merge pull request #2238 from department-of-veterans-affairs/bug/LEAF…
Pelentan Nov 21, 2023
f2c5f2a
Merge pull request #2235 from department-of-veterans-affairs/issue/LE…
Pelentan Nov 21, 2023
075f781
Merge pull request #2233 from department-of-veterans-affairs/enhance/…
Pelentan Nov 21, 2023
6b472fc
Merge pull request #2229 from department-of-veterans-affairs/enhance/…
Pelentan Nov 21, 2023
24ef710
Merge pull request #2223 from department-of-veterans-affairs/feature/…
Pelentan Nov 21, 2023
ecf68df
Merge pull request #2224 from department-of-veterans-affairs/enhance/…
Pelentan Nov 21, 2023
aa5ea45
fix
raphaelfretter Nov 21, 2023
17ca95f
LEAF 2569 updates from master and resolve c
aerinkayne Nov 27, 2023
3d62e7b
LEAF 2747 style updates to notification info
aerinkayne Nov 27, 2023
bb2a8f2
Merge pull request #2246 from department-of-veterans-affairs/enhance/…
Pelentan Nov 27, 2023
13c25db
LEAF 2569 match rc font color
aerinkayne Nov 27, 2023
f8dd349
LEAF 3188 rm button brackets, add file name to title, add alternating…
aerinkayne Nov 27, 2023
5dd46de
Merge pull request #2247 from department-of-veterans-affairs/enhance/…
Pelentan Nov 27, 2023
ff75803
LEAF-4165 - User Access Group History
jrodcode Nov 28, 2023
63e05d6
LEAF 4166 prevent checkmark if initial value is empty
aerinkayne Nov 28, 2023
d468d29
improve customizability
mgaoVA Nov 28, 2023
a6004d5
avoid ambiguous query when used in combination with a data query
mgaoVA Nov 28, 2023
7428ff5
prevent invalid query
mgaoVA Nov 28, 2023
b2b329e
LEAF-4107-Remove-Console-Logs-From-Editors
jrodcode Nov 29, 2023
9f55caa
fix wrong name
mgaoVA Nov 29, 2023
15d618a
LEAF-4107-Update
jrodcode Nov 29, 2023
ab4462f
Merge pull request #2227 from department-of-veterans-affairs/enhancem…
Pelentan Dec 1, 2023
fcfdad9
Merge pull request #2230 from department-of-veterans-affairs/enhancem…
Pelentan Dec 1, 2023
cf32cd5
LEAF 4183 update file upload validator to check input files
aerinkayne Dec 1, 2023
e445150
reset limit counter on subsequent runs
mgaoVA Dec 1, 2023
f2df397
track state
mgaoVA Dec 1, 2023
ec4009c
Merge pull request #2254 from department-of-veterans-affairs/issue/LE…
Pelentan Dec 4, 2023
50dc95b
Merge pull request #2245 from department-of-veterans-affairs/rc/2023-…
Pelentan Dec 5, 2023
9e4fd42
Merge pull request #2256 from department-of-veterans-affairs/persist-…
Pelentan Dec 5, 2023
4cf9732
Merge pull request #2253 from department-of-veterans-affairs/LEAF-410…
Pelentan Dec 5, 2023
04d779b
Merge pull request #2252 from department-of-veterans-affairs/prevent-…
Pelentan Dec 5, 2023
665a177
Merge pull request #2251 from department-of-veterans-affairs/avoid-am…
Pelentan Dec 5, 2023
3fbb33d
Merge pull request #2250 from department-of-veterans-affairs/improve-…
Pelentan Dec 5, 2023
20ed8cf
Merge pull request #2249 from department-of-veterans-affairs/issue/LE…
Pelentan Dec 5, 2023
16c14b8
Merge pull request #2248 from department-of-veterans-affairs/LEAF-416…
Pelentan Dec 5, 2023
eeed65f
Merge pull request #2244 from department-of-veterans-affairs/fix/LEAF…
Pelentan Dec 5, 2023
8c5fb33
Merge pull request #2234 from department-of-veterans-affairs/issue/LE…
Pelentan Dec 5, 2023
20524c1
hotfix sub email template
Dec 8, 2023
a75d04f
modification made
Dec 8, 2023
4712fbd
Merge pull request #2259 from department-of-veterans-affairs/hotfix-s…
pete-nerantzinis Dec 8, 2023
affc4c9
Merge pull request #2257 from department-of-veterans-affairs/rc/2023-…
Pelentan Dec 18, 2023
406aa63
revert some group API changes
mgaoVA Jan 12, 2024
b84be54
undo PDO transaction change: no difference
mgaoVA Jan 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions LEAF_Nexus/js/employeeSelector.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ function employeeSelector(containerID) {
this.intervalID = null;
this.selectHandler = null;
this.resultHandler = null;
this.selectHandlers = [];
this.selectLink = null;
this.selectionData = new Object();
this.optionNoLimit = 0;
Expand Down Expand Up @@ -108,6 +109,7 @@ employeeSelector.prototype.select = function (id) {
if (this.selectHandler != null) {
this.selectHandler();
}
this.selectHandlers.forEach(selectHandler => selectHandler());
};

employeeSelector.prototype.setSelectHandler = function (func) {
Expand All @@ -118,6 +120,15 @@ employeeSelector.prototype.setResultHandler = function (func) {
this.resultHandler = func;
};

employeeSelector.prototype.addSelectHandler = function (func) {
if(typeof func == 'function') {
this.selectHandlers.push(func);
}
else {
console.error('argument supplied to addSelectHandler must be a function');
}
};

employeeSelector.prototype.setSelectLink = function (link) {
this.selectLink = link;
};
Expand Down
11 changes: 11 additions & 0 deletions LEAF_Nexus/js/nationalEmployeeSelector.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ function nationalEmployeeSelector(containerID) {
this.intervalID = null;
this.selectHandler = null;
this.resultHandler = null;
this.selectHandlers = [];
this.selectLink = null;
this.selectionData = new Object();
this.optionNoLimit = 0;
Expand Down Expand Up @@ -161,6 +162,7 @@ nationalEmployeeSelector.prototype.select = function (id) {
if (this.selectHandler != null) {
this.selectHandler();
}
this.selectHandlers.forEach(selectHandler => selectHandler());
};

nationalEmployeeSelector.prototype.setSelectHandler = function (func) {
Expand All @@ -171,6 +173,15 @@ nationalEmployeeSelector.prototype.setResultHandler = function (func) {
this.resultHandler = func;
};

nationalEmployeeSelector.prototype.addSelectHandler = function (func) {
if(typeof func == 'function') {
this.selectHandlers.push(func);
}
else {
console.error('argument supplied to addSelectHandler must be a function');
}
};

nationalEmployeeSelector.prototype.setSelectLink = function (link) {
this.selectLink = link;
};
Expand Down
14 changes: 10 additions & 4 deletions LEAF_Nexus/js/orgchartForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ orgchartForm.prototype.getForm = function (UID, categoryID, indicatorID) {
success: function (response) {
dialog.setContent(response);
$("input:visible:first, select:visible:first").focus();
$("input:visible:first, select:visible:first").keypress(function (
$("input:visible:first, select:visible:first").on("keydown", function (
event
) {
if (event.which == 13) {
Expand Down Expand Up @@ -100,11 +100,17 @@ orgchartForm.prototype.getForm = function (UID, categoryID, indicatorID) {
success: function (response) {
dialog.setContent(response);
$("input:visible:first, select:visible:first").focus();
$("input:visible:first, select:visible:first").keypress(function (
$("input:visible:first, select:visible:first").on("keydown", function (
event
) {
if (event.which == 13) {
$("#" + dialog.btnSaveID).trigger("click");
let elChosenDrop = null;
if(event.target.classList.contains('chosen-search-input')) {
elChosenDrop = document.querySelector('.chosen-with-drop');
}
if(elChosenDrop === null) { //if a chosen dropdown box is still open, the first enter will just close it.
$("#" + dialog.btnSaveID).trigger("click");
}
}
});
},
Expand Down Expand Up @@ -137,7 +143,7 @@ orgchartForm.prototype.getForm = function (UID, categoryID, indicatorID) {
success: function (response) {
dialog.setContent(response);
$("input:visible:first, select:visible:first").focus();
$("input:visible:first, select:visible:first").keypress(function (
$("input:visible:first, select:visible:first").on("keydown", function (
event
) {
if (event.which == 13) {
Expand Down
6 changes: 3 additions & 3 deletions LEAF_Nexus/templates/view_position.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,9 @@ $(function() {
orgchartForm = new orgchartForm('orgchartForm');
orgchartForm.initialize();
orgchartForm.addUpdateEvent(19, function(response) {
if(($('.employee').size() - 1) < $('#data_19_2_<!--{$positionID}-->').html()) {
window.location.reload();
}
if(($('.employee').length - 1) < $('#data_19_2_<!--{$positionID}-->').html()) {
window.location.reload();
}
});
// include file="site_elements/orgchartForm_updateOutlook.js.tpl"

Expand Down
5 changes: 2 additions & 3 deletions LEAF_Request_Portal/admin/css/mod_templates.css
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

.CodeMirror,
.cm-s-default {
height: auto !important;
height: 85vh !important;
border-radius: 0 0 0 5px;
}

Expand Down Expand Up @@ -69,7 +69,7 @@

.CodeMirror-merge,
.CodeMirror-merge .CodeMirror {
height: 60vh !important;
height: 85vh !important;
}

.CodeMirror-merge-2pane .CodeMirror-merge-pane {
Expand Down Expand Up @@ -450,7 +450,6 @@

.CodeMirror-scroll {
margin-right: 0;
height: 60vh;
min-height: 563px;
}

Expand Down
6 changes: 3 additions & 3 deletions LEAF_Request_Portal/admin/css/mod_templates_reports.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* TODO: Consolidate with mod_templates.css */
.ui-dialog .ui-dialog-content {
box-sizing: border-box;
}
Expand Down Expand Up @@ -27,7 +28,7 @@

.CodeMirror,
.cm-s-default {
height: auto !important;
height: 85vh !important;
border-radius: 0 0 0 5px;
}

Expand Down Expand Up @@ -83,7 +84,7 @@

.CodeMirror-merge,
.CodeMirror-merge {
height: 60vh !important;
height: 85vh !important;
}

.CodeMirror-merge-2pane .CodeMirror-merge-pane {
Expand Down Expand Up @@ -525,7 +526,6 @@

.CodeMirror-scroll {
margin-right: 0;
height: 60vh;
}

.CodeMirror-sizer {
Expand Down
49 changes: 11 additions & 38 deletions LEAF_Request_Portal/admin/templates/mod_form.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,10 @@

<script>
const orgchartPath = '<!--{$orgchartPath}-->';
let vueData = {
indicatorID: 0,
updateIndicatorList: false
}
function updateVueData(indicatorID) {
vueData.indicatorID = parseInt(indicatorID);
let ifThenIndicatorID = 0; //used by conditions editor app. set to specific indicatorID when the app is used, and reset to 0 when closed
/* update ifThen indicator ID and dispatch a click event to a hidden button on the conditions editor app to update the childID */
function updateVueData(indicatorID = 0) {
ifThenIndicatorID = parseInt(indicatorID);
document.getElementById('btn-vue-update-trigger').dispatchEvent(new Event("click"));
}

Expand Down Expand Up @@ -335,8 +333,7 @@ function openContent(url) {
dataType: 'text', // IE9 issue
success: function(res) {
$('#formEditor_form').empty().html(res);
vueData.indicatorID = 0;
document.getElementById('btn-vue-update-trigger').dispatchEvent(new Event("click"));
updateVueData(0);
},
error: function(res) {
$('#formEditor_form').empty().html(res);
Expand Down Expand Up @@ -958,8 +955,6 @@ function newQuestion(parentIndicatorID = null) {
CSRFToken: '<!--{$CSRFToken}-->'},
success: function(res) {
if(res != null) {
vueData.updateIndicatorList = true;
document.getElementById('btn-vue-update-trigger').dispatchEvent(new Event("click"));
if($('#sort').val() != '') {
$.ajax({
type: 'POST',
Expand Down Expand Up @@ -1052,7 +1047,12 @@ function makeGrid(columns) {
}
$(gridBodyElement + ' > div:eq(' + i + ')').css('padding-bottom', '11px');
if($(gridBodyElement + ' > div:eq(' + i + ') > span.dropdown').length === 0){
$(gridBodyElement + ' > div:eq(' + i + ')').append('<span class="dropdown"><div>One option per line</div><textarea aria-label="Dropdown options, one option per line" style="width: 153px; resize: none;"value="">' + options + '</textarea></span>');
$(gridBodyElement + ' > div:eq(' + i + ')').append(
`<span class="dropdown">
<div>One option per line</div>
<textarea aria-label="Dropdown options, one option per line" style="width: 153px; resize: none;"value="">${options}</textarea>
</span>`
);
}
}
if(gridJSON[i].type.toString() === 'dropdown_file') {
Expand Down Expand Up @@ -1665,8 +1665,6 @@ function getForm(indicatorID, series) {
}

$.when.apply(undefined, calls).then(function() {
vueData.updateIndicatorList = true;
document.getElementById('btn-vue-update-trigger').dispatchEvent(new Event("click"));
openContent('ajaxIndex.php?a=printview&categoryID='+ currCategoryID);
dialog.hide();
});
Expand Down Expand Up @@ -1698,31 +1696,6 @@ function gridDropdown(dropDownOptions){
return returnArray;
}

/**
* Purpose: Create Array for Multi-Select Options
* @param multiSelectOptions
* @returns {[]|*}
*/
function gridMultiselect(multiSelectOptions){
if(multiSelectOptions == null || multiSelectOptions.length === 0){
return multiSelectOptions;
}
let uniqueNames = multiSelectOptions.split("\n");
let returnArray = [];
uniqueNames = uniqueNames.filter(function(elem, index, self) {
return index == self.indexOf(elem);
});

$.each(uniqueNames, function(i, el){
if(el === "no") {
uniqueNames[i] = "No";
}
returnArray.push(uniqueNames[i]);
});

return returnArray;
}

/**
* Purpose: Create Array for Multi-Answer Text
* @param multiAnswerValue
Expand Down
Loading
Loading