Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaf 4209 - Revert some changes related to the Group API subsystem #2272

Merged
merged 105 commits into from
Jan 30, 2024
Merged

Leaf 4209 - Revert some changes related to the Group API subsystem #2272

merged 105 commits into from
Jan 30, 2024

Conversation

mgaoVA
Copy link
Collaborator

@mgaoVA mgaoVA commented Jan 12, 2024

This makes a few changes:

  • Removes the "groups" property for each member returned by ./api/group/[GROUP ID]/members -- See potential impact
    • "groups" within groups seems redundant and represents an O(N^2) complexity lookup, which causes very slow response times on large sites
  • Revert the return structure of Groups.php -> getMembers()
  • Removes the use of async: false
  • Updates a HTTP DELETE request
  • Removes redundant error messages

Potential Impact

  • Viewing and modifying groups and their members
  • Does anything depend on the groups property within each api/group/[GROUP ID]/members entry?

Testing

  • Admins should be able to view/modify groups and their members

mgaoVA and others added 30 commits October 27, 2023 14:27
@mgaoVA
don't run invalid queries
011d48e
@aerinkayne
LEAF 2285 initial grid multiselect dropd, update repetitive row logic
d582844
@aerinkayne
LEAF 2285 mv controls template and data value cell search to methods,…
c7f0834 
… cleanup
@mgaoVA
implement fulltext search
04c3f7b
@mgaoVA
should be safe?
2345899
@mgaoVA
mask wildcards when they're implicit
82b7455
@mgaoVA
update search syntax
6dacb9e
@mgaoVA
optimize fulltext search
9f950e0
@mgaoVA
fix negative search
a3067fe
@aerinkayne
LEAF 2285 gridInput cleanup
ecca09c 
Remove multisel option from formeditor - waiting on other updates.
Clean up some template areas of gridInput and move table data entry,
and column id -- data value checking to methods.
@mgaoVA
update defaults, resolve employee prefill issue
b0b4b25
@mgaoVA
remove unused
5e00613
@mgaoVA
improve defaults
b38813e
@aerinkayne
LEAF 4111 fix non unique id, rename some variables, template cleanup
be63bb9
@aerinkayne
Merge branch 'feature/LEAF-2285/grid_format_multiselect_dropdown' int…
6705b15 
…o enhance/LEAF-4111/gridInput_file_cleanup
@mgaoVA
update ux
fcba798
@aerinkayne
LEAF 4111 style fix, rm unused multiselect change, add method comments
6eebdf7
@mgaoVA
optimize group designated hotspot
f20a49f
@mgaoVA
update default and add comment
ffa4103
@aerinkayne
LEAF 4111 adjust opt addition, add check for null value
1091bc2
Leaf 4084 - custom emails added to subordinate
fa3c5ad
Leaf 4084 - PR comments addressed
568a2ca
@aerinkayne
LEAF 3188 initial updates for upload formats
89927be
@aerinkayne
LEAF 3188 mv method, adjust loading indicator
f013c58
Leaf 4116 - Find a string
484de40
Leaf 4084 - Directory exist
ad8e623
@mgaoVA
fix type check issue, allow files to be embedded
ffaf673
@aerinkayne
LEAF 3188 add aria attr
a8b7783
@aerinkayne
LEAF research - hideshow remaining formats excluding raw_data
56b95b2
Leaf 4084 - PR comments updated
ed0e730
Pelentan and others added 16 commits December 5, 2023 08:52
@Pelentan
Merge pull request #2245 from department-of-veterans-affairs/rc/2023-…
50dc95b 
…21-14/Sprint-65-c2

Rc/2023 21 14/sprint 65 c2
@Pelentan
Merge pull request #2256 from department-of-veterans-affairs/persist-…
9e4fd42 
…original-parameters

Leaf 4186 - Persist original parameters
@Pelentan
Merge pull request #2253 from department-of-veterans-affairs/LEAF-410…
4cf9732 
…7-Remove-Console-Logs-From-Editors

LEAF-4107-Remove-Console-Logs-From-Editors
@Pelentan
Merge pull request #2252 from department-of-veterans-affairs/prevent-…
04d779b 
…invalid-query

Leaf 4173 - Prevent invalid query
@Pelentan
Merge pull request #2251 from department-of-veterans-affairs/avoid-am…
665a177 
…biguous-query

Leaf 4172 - Avoid ambiguous query when used in combination with a data query
@Pelentan
Merge pull request #2250 from department-of-veterans-affairs/improve-…
3fbb33d 
…customizability

Leaf 4171 - Improve customizability for Employee Selector
@Pelentan
Merge pull request #2249 from department-of-veterans-affairs/issue/LE…
20ed8cf 
…AF-4166/checkboxes_prevent_empty_value_checkmark

LEAF 4166 prevent checkmark if initial value is empty
@Pelentan
Merge pull request #2248 from department-of-veterans-affairs/LEAF-416…
16c14b8 
…5-User-Access-Group-History

LEAF-4165 - User Access Group History
@Pelentan
Merge pull request #2244 from department-of-veterans-affairs/fix/LEAF…
eeed65f 
…-4155/custom_email_fields_fix

LEAF-4155: Custom Fields not added to non-custom email templates
@Pelentan
Merge pull request #2234 from department-of-veterans-affairs/issue/LE…
8c5fb33 
…AF-2569/report_builder_on_and_before

LEAF 2569 Form Search dateSubmitted on and before user information
hotfix sub email template
20524c1
modification made
a75d04f
@pete-nerantzinis
Merge pull request #2259 from department-of-veterans-affairs/hotfix-s…
4712fbd 
…ub-email

Leaf 4192 - hotfix sub email template
@Pelentan
Merge pull request #2257 from department-of-veterans-affairs/rc/2023-…
affc4c9 
…12-5/Sprint-65-c3

Rc/2023 12 5/sprint 65 c3
@mgaoVA
revert some group API changes
406aa63 
use PDO transactions
@mgaoVA
undo PDO transaction change: no difference
b84be54
@jampaul3 jampaul3 changed the title Revert some changes related to the Group API subsystem Leaf 4209 - Revert some changes related to the Group API subsystem Jan 22, 2024
@Pelentan Pelentan added the With QA Ticket is to QA. No changes unless pulled back to in progress label Jan 29, 2024
@Pelentan Pelentan changed the base branch from master to rc/2023-11-07/Sprint-64-c2 January 30, 2024 16:15
@Pelentan Pelentan merged this pull request into rc/2023-11-07/Sprint-64-c2 Jan 30, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jampaul3 jampaul3 jampaul3 approved these changes

@shaneodd shaneodd shaneodd approved these changes

@aerinkayne aerinkayne aerinkayne approved these changes

@Pelentan Pelentan Pelentan approved these changes

@pete-nerantzinis pete-nerantzinis Awaiting requested review from pete-nerantzinis

@raphaelfretter raphaelfretter Awaiting requested review from raphaelfretter

Assignees
No one assigned
Labels
With QA Ticket is to QA. No changes unless pulled back to in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mgaoVA @Pelentan @aerinkayne @shaneodd @jampaul3 @pete-nerantzinis @raphaelfretter @jrodcode