Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(nix): add outputs for Android binaries #5335

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Mar 11, 2024

This change will result in automatic publishing Android binaries for deltachat-rpc-server when GitHub release is published. Normal musl-based Linux binaries are difficult to use on Android because they expect /etc/resolv.conf to contain nameserver addresses, while on Android this file is not present and DNS works via UNIX socket proxy that only bionic libc uses.

Using NDK 24 because NDK 23 does not have getauxval() function. In Delta Chat Android we use NDK 23, but this requires building our own fake getauxval().

No wheels yet and they are not planned for this PR because we cannot upload them to PyPI anyway.
For wheels we can use https://peps.python.org/pep-0738/ as a standard for wheel tags, e.g. android_21_arm64_v8a, android_21_x86_64, android_16_x86, android_16_armeabi_v7a.
If we build such wheels, we need to publish them to some other registry. GitHub Packages does not support Python yet.

@link2xt link2xt force-pushed the link2xt/deltachat-rpc-server-android branch 2 times, most recently from 5a0bd9e to 21e3cbc Compare March 19, 2024 16:00
Using NDK 24 because NDK 23 does not have getauxval() function.
@link2xt link2xt force-pushed the link2xt/deltachat-rpc-server-android branch from 21e3cbc to f9dbd86 Compare March 24, 2024 03:25
@link2xt
Copy link
Collaborator Author

link2xt commented Mar 24, 2024

This is ready for review.
Testing by manually triggering workflow with gh workflow run deltachat-rpc-server.yml --ref link2xt/deltachat-rpc-server-android. This builds all the binaries but does not upload them because there is no release.
Runs can be seen at https://github.com/deltachat/deltachat-core-rust/actions/workflows/deltachat-rpc-server.yml

@link2xt link2xt requested review from r10s, adbenitez and iequidoo March 24, 2024 03:35
@link2xt link2xt force-pushed the link2xt/deltachat-rpc-server-android branch from f9dbd86 to f0bf9cd Compare March 24, 2024 03:43
@link2xt link2xt force-pushed the link2xt/deltachat-rpc-server-android branch from f0bf9cd to e36053a Compare March 24, 2024 03:45
@link2xt link2xt merged commit ebd097b into main Mar 28, 2024
49 of 52 checks passed
@link2xt link2xt deleted the link2xt/deltachat-rpc-server-android branch March 28, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant