-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): allow presets to be explored in dedicated page #1232
Conversation
I am looking to display comments on the user profile page. So we might be running into design conflicts here with the changes to the user page. Also I am wondering what would happen in your implementation you requested to show more of the users scratches? Would that just extend the preset section further down the page? I am just thinking maybe to future proof this a little we add tabs to the user profile page that can then be added onto with future features such as this. |
I'm not sure comments belong on a user page since you lose the context of the scratch to just have a bunch of comments. or maybe there's a way to do that you have in your head I'm not considering. but yeah I am down with the tabs idea, I think |
Another thought: I think showing a few presets at the top of a platform page is good, but if we list all of them, the scratches will be quite far down the page. maybe we could do the tabs thing there too, or a two-column view? not sure.. |
d5692dc
to
a80cdae
Compare
I simplified this PR, by only adding the I also think it would be great to have some presets in the platform page, but adding a tab section could be another PR! |
this looks great! a few thoughts:
|
(3 and 4 should probably be addressed in this PR before merge, and I can write an issue for 1 and 2) |
1571cee
to
1b76677
Compare
@ethteck 3 ans 4 have been implemented ✅ |
I like this PR! Thanks for the contribution - just some small code style things to fix up. |
1b76677
to
3173b63
Compare
Result can be visible through the vercel deployment https://frontend-git-fork-axel7083-feature-frontend-presets-decompme.vercel.app/preset |
Thanks for the fixes :) Looks like there are some conflicts. Soon as they're resolved we can merge this👍 |
3173b63
to
a29c8c4
Compare
Yeahhh, should be good now :) |
@bates64 ready to be merge ! |
Description
This PR make the presets easier to explore and integrate them as part of the UI with the related resources.
Screenshots
/preset
The new preset page allows to list all the presets by platform. I am reusing the component from the
NewScratchForm
.Related issues
Related to #648