Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added user profile tabs & migrated scratch panels #1240

Merged
merged 1 commit into from
May 22, 2024
Merged

Added user profile tabs & migrated scratch panels #1240

merged 1 commit into from
May 22, 2024

Conversation

conorgolden1
Copy link
Contributor

Discussed in #1232

bates64
bates64 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@bates64 bates64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Impressive cleanup and improvement, nice work!
Let's remember to maintain the URL when we add tabs to profiles, i.e. changing tab changes the URL

@bates64 bates64 merged commit ac3ae73 into decompme:main May 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bates64 bates64 bates64 approved these changes

@ethteck ethteck ethteck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorgolden1 @ethteck @bates64