-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary logic for retrieving agg time dimension for conversion metrics #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDee
force-pushed
the
will/fix-conversion-window
branch
from
October 30, 2024 04:12
91d68b2
to
577bd26
Compare
WilliamDee
force-pushed
the
will/fix-conversion-window
branch
from
October 30, 2024 21:00
e1cc8f4
to
fe18643
Compare
WilliamDee
added
the
Reload Test Data in SQL Engines
Should be run when test data changes
label
Oct 30, 2024
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
October 30, 2024 21:23 — with
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
October 30, 2024 21:23 — with
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
October 30, 2024 21:23 — with
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
October 30, 2024 21:23 — with
GitHub Actions
Inactive
github-actions
bot
removed
the
Reload Test Data in SQL Engines
Should be run when test data changes
label
Oct 30, 2024
WilliamDee
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Oct 30, 2024
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
October 30, 2024 21:29 — with
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
October 30, 2024 21:29 — with
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
October 30, 2024 21:29 — with
GitHub Actions
Inactive
WilliamDee
temporarily deployed
to
DW_INTEGRATION_TESTS
October 30, 2024 21:29 — with
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Oct 30, 2024
courtneyholcomb
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For conversion metrics, we use the agg time dimesnion of each measure to do the conversion window calculation. Since we have
metric_time
which is already referencing the agg time dimension of a given semantic model, we don't need to use the actual agg time dimension reference. This removes the need for additional logic in the code as well as duplication in the rendered SQL.Note: This should not affect any changes in the query result and should be just removing unnecessary duplication in the rendered SQL
Example
Currently, the rendered SQL
Now,