Skip to content

Commit

Permalink
address review
Browse files Browse the repository at this point in the history
  • Loading branch information
WilliamDee committed Oct 30, 2024
1 parent 99ee154 commit 577bd26
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions metricflow/dataflow/builder/dataflow_plan_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,6 @@ def _build_aggregated_conversion_node(
# Due to other outstanding issues with conversion metric filters, we disable predicate
# pushdown for any filter parameter set that is not part of the original time range constraint
# implementation.
default_granularity = ExpandedTimeGranularity.from_time_granularity(
self._metric_lookup.get_min_queryable_time_granularity(metric_spec.reference)
)
disabled_pushdown_state = PredicatePushdownState.with_pushdown_disabled()
time_range_only_pushdown_state = PredicatePushdownState(
time_range_constraint=predicate_pushdown_state.time_range_constraint,
Expand Down Expand Up @@ -309,6 +306,9 @@ def _build_aggregated_conversion_node(
# Get the time dimension used to calculate the conversion window
# Currently, both the base/conversion measure uses metric_time as it's the default agg time dimension.
# However, eventually, there can be user-specified time dimensions used for this calculation.
default_granularity = ExpandedTimeGranularity.from_time_granularity(
self._metric_lookup.get_min_queryable_time_granularity(metric_spec.reference)
)
metric_time_dimension_spec = DataSet.metric_time_dimension_spec(default_granularity)

# Filter the source nodes with only the required specs needed for the calculation
Expand Down

0 comments on commit 577bd26

Please sign in to comment.