Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused DimensionSpecResolver class #1389

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Remove unused DimensionSpecResolver class #1389

merged 1 commit into from
Sep 3, 2024

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Sep 3, 2024

The DimensionSpecResolver did something or other with where
clause inputs, but it is not used anymore, if it ever was.

@cla-bot cla-bot bot added the cla:yes label Sep 3, 2024
This was referenced Sep 3, 2024
Merged
Merged
@tlento Graphite App
Copy link
Contributor Author

tlento commented Sep 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlento and the rest of your teammates on Graphite Graphite

This was referenced Sep 3, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@tlento tlento marked this pull request as ready for review September 3, 2024 19:42
courtneyholcomb
courtneyholcomb approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking - I assume you already checked to make sure this isn't used in other repos? If so thennnn :shipit:

@tlento tlento force-pushed the allow-arbitrary-granularity-names-in-structured-linkable-spect-name branch from c8ca0af to dafccd5 Compare September 3, 2024 20:51
@tlento tlento force-pushed the remove-unused-classes branch from e0f58ae to e865858 Compare September 3, 2024 20:51
@tlento
Copy link
Contributor Author

tlento commented Sep 3, 2024

just checking - I assume you already checked to make sure this isn't used in other repos? If so thennnn

I did, checked MFS locally and used GitHub search for the org. Seems ok!

@tlento Graphite App
Copy link
Contributor Author

tlento commented Sep 3, 2024 •
edited
Loading

Merge activity

  • Sep 3, 3:08 PM PDT: @tlento started a stack merge that includes this pull request via Graphite.
  • Sep 3, 3:20 PM PDT: Graphite rebased this pull request as part of a merge.
  • Sep 3, 3:23 PM PDT: @tlento merged this pull request with Graphite.

@tlento tlento changed the base branch from allow-arbitrary-granularity-names-in-structured-linkable-spect-name to graphite-base/1389 September 3, 2024 22:14
@tlento tlento changed the base branch from graphite-base/1389 to main September 3, 2024 22:18
@tlento
Remove unused DimensionSpecResolver class
21666c7 
The DimensionSpecResolver did something or other with where
clause inputs, but it is not used anymore, if it ever was.
@tlento tlento force-pushed the remove-unused-classes branch from e865858 to 21666c7 Compare September 3, 2024 22:19
@tlento tlento merged commit 5861b91 into main Sep 3, 2024
16 checks passed
@tlento tlento deleted the remove-unused-classes branch September 3, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@courtneyholcomb courtneyholcomb courtneyholcomb approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlento @courtneyholcomb