Add ExpandedTimeGranularity struct to linkable elements #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the impending introduction of custom granularities, which are named granularities accessed via a lookup keyed by a date/time value with a specified base grain, our reliance on raw TimeGranularity enumeration elements will no longer be sufficient for managing dataflow plans or queries. In order to be able to reference custom granularities in our TimeDimensionSpec and associated ElementPathKey and LinkableElement subclasses we need to make space for both the granularity name and a base grain value. This change adds an ExpandedTimeGranularity struct to encapsulate both of these pieces of information in a single object value, and switches the LinkableDimension time granularity property to use it in place of the bare TimeGranularity enum value. This is just the first step. Later changes will migrate most internal TimeGranularity-typed properties to the new ExpandedTimeGranularity construct. Once we have a proof of concept for this working we will decide whether this construct belongs in dbt-semantic-interfaces or if we can keep this internal to MetricFlow. The main reason to expand this is for more natural support for time windows and offsets, but we may be able to simply allow strings in the protocol spec and convert them to the struct types inside of MetricFlow.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the impending introduction of custom granularities,
which are named granularities accessed via a lookup keyed
by a date/time value with a specified base grain, our reliance
on raw TimeGranularity enumeration elements will no longer
be sufficient for managing dataflow plans or queries.
In order to be able to reference custom granularities in
our TimeDimensionSpec and associated ElementPathKey and
LinkableElement subclasses we need to make space for both
the granularity name and a base grain value.
This change adds an ExpandedTimeGranularity struct to
encapsulate both of these pieces of information in a single
object value, and switches the LinkableDimension time granularity
property to use it in place of the bare TimeGranularity enum value.
This is just the first step. Later changes will migrate most
internal TimeGranularity-typed properties to the new ExpandedTimeGranularity
construct.
Once we have a proof of concept for this working we will decide
whether this construct belongs in dbt-semantic-interfaces or if we can
keep this internal to MetricFlow. The main reason to expand this
is for more natural support for time windows and offsets, but
we may be able to simply allow strings in the protocol spec and
convert them to the struct types inside of MetricFlow.