Use LinkableSpecSet in WhereFilterSpec
#1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WhereFilterSpec`. This allows it to be serializable.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
plypaul
force-pushed
the
p--query-resolution-perf--09
branch
from
e35d7d1 to
24758ee
Compare
courtneyholcomb
approved these changes
Jul 16, 2024
| @@ -61,7 +66,7 @@ def merge(self, other: WhereFilterSpec) -> WhereFilterSpec: # noqa: D102 | |||
| return WhereFilterSpec( | |||
| where_sql=f"({self.where_sql}) AND ({other.where_sql})", | |||
| bind_parameters=self.bind_parameters.combine(other.bind_parameters), | |||
| linkable_specs=ordered_dedupe(self.linkable_specs, other.linkable_specs), | |||
There was a problem hiding this comment.
Does the ordering matter from the previous code? Just checking since it looks like it was removed in the new code
There was a problem hiding this comment.
The .dedupe() call is actually ordered, so it should be the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
WhereFilterSpec, the fieldlinkable_specscan't be used withSerializableDataclasssince it's an interface. This PR changes that field to aLinkableSpecSet.