Update fields in LinkableElement-related classes to use tuples
#1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
p--query-resolution-perf--09
branch
from
e35d7d1 to
24758ee
Compare
plypaul
force-pushed
the
p--query-resolution-perf--10
branch
2 times, most recently
from
5e910ac to
2cba144
Compare
plypaul
changed the title
LinkableElementUnion in WhereFilterSpecLinkableElement-related classes to use tuples
courtneyholcomb
approved these changes
Jul 16, 2024
| properties: Tuple[LinkableElementProperty, ...] | ||
|
|
||
| def __post_init__(self) -> None: # noqa: D105 | ||
| assert len(self.property_set) == len(self.properties) |
There was a problem hiding this comment.
Can we add error messages to these asserts to help devs if they run into this in development?
…operties` to be a tuple. This aligns with `SerializableDataclass` since sets are current not supported.
plypaul
force-pushed
the
p--query-resolution-perf--10
branch
from
2cba144 to
42ea1eb
Compare
plypaul
force-pushed
the
p--query-resolution-perf--10
branch
from
e71a515 to
9ace719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, serialization of sets is not supported so this PR changes the
propertiesfield of a fewLinkableElementrelated classes to a tuple-based implementation.