fix: Add Column Header to the exported CSV from query command #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSV file generated using `mf query --csv <csv-file-name>` does not contain the header. This commit updates the function to include the column header as well
tlento
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Thanks for the fix @saurabh0402 ! Apologies for the delay, I was on vacation and most of the team relies on reviewer tags.
Could you add a changelog entry to this PR? See the contributing guide for instructions. That'll also ensure you get properly credited in our release notes.
Thank you!
|
Hey @tlento, thanks for reviewing this. I have added the changelog, please take a look now. |
tlento
approved these changes
Jul 16, 2024
|
Hey @tlento, when can we expect this to be released? |
|
End of next week, maybe? I need to fix up some deployment issues to allow for a backport and patch release on dbt-metricflow, and that takes some time to test. |
|
Thanks a lot. |
tlento
pushed a commit
that referenced
this pull request
Jul 26, 2024
# Issue #1285 The CSV exported from the `mf query <metric> --csv <csv-file-name>` command does not contain the column header. The CSV thus does not make too much sense. # Fix - The code [here](https://github.com/dbt-labs/metricflow/blob/main/dbt-metricflow/dbt_metricflow/cli/main.py#L344) is writing data to the CSV file. The column names aren't getting added to the file. - With this PR, we are adding the column names returned from `df.column_names` to the CSV to fix the issue.
tlento
added a commit
that referenced
this pull request
Jul 27, 2024
…1354) This commit is a backport of PR #1313 to dbt-metricflow 0.7.x This will allow us to deploy @saurabh0402's fix for the following issue: #1285 Note - efficacy was tested via the CLI by running hatch build and doing a pip install of the build package into a clean VM, and running `mf query` with the `--csv` flag enabled. Co-authored-by: Saurabh Kumar <[email protected]>
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1285
The CSV exported from the
mf query <metric> --csv <csv-file-name>command does not contain the column header. The CSV thus does not make too much sense.Fix
df.column_namesto the CSV to fix the issue.