Backport: Add Column Header to the exported CSV from query command #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Issue #1285 The CSV exported from the `mf query <metric> --csv <csv-file-name>` command does not contain the column header. The CSV thus does not make too much sense. # Fix - The code [here](https://github.com/dbt-labs/metricflow/blob/main/dbt-metricflow/dbt_metricflow/cli/main.py#L344) is writing data to the CSV file. The column names aren't getting added to the file. - With this PR, we are adding the column names returned from `df.column_names` to the CSV to fix the issue.
tlento
changed the title
plypaul
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of #1313 to dbt-metricflow 0.7.x
This will allow us to deploy @saurabh0402's fix for the following issue:
#1285
Note - efficacy was tested via the CLI by running hatch build and doing a pip install
of the build package into a clean VM, and running
mf querywith the--csvflagenabled.