Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow LinkableMetrics for case when entity reference is in entity links #1200

Merged
merged 1 commit into from
May 11, 2024
+4 −0
Merged

Don't allow LinkableMetrics for case when entity reference is in entity links #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions metricflow-semantics/metricflow_semantics/model/semantics/linkable_spec_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,10 @@ def __init__(
)
for linkable_entities in linkable_element_set_for_metric.path_key_to_linkable_entities.values():
for linkable_entity in linkable_entities:
# TODO: some users encounter a situation in which the entity reference is in the entity links. Debug why.
if linkable_entity.reference in linkable_entity.entity_links:
logger.info(f"Found entity reference in entity links for linkable entity: {linkable_entity}")
continue
metric_subquery_join_path_element = MetricSubqueryJoinPathElement(
metric_reference=metric_reference,
derived_from_semantic_models=defined_from_semantic_models,
Expand Down
Loading