Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow LinkableMetrics for case when entity reference is in entity links #1200

Merged
merged 1 commit into from
May 11, 2024

Conversation

courtneyholcomb
Copy link
Contributor

Description

Some users have run into a scenario where the entity reference can be found in the entity links for some LinkableEntities. I haven't yet been able to reproduce that error with our test configs. Releasing metrics as dimensions is blocked on this edge case, so I'm skipping that scenario here to ensure that customers won't run into it until when using LinkableMetrics until we can debug further. This will allow us to release the feature and handle this case in a follow up version.

Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks good, per lengthy discussion about what this means:

  1. Our current hypothesis is this is a multi-hop join of something like listing -> account and then there are multiple datasets with a primary account entity
  2. This logging will show us what these paths look like and how common they are
  3. This is most likely correct behavior given how metric joins are meant to work, certainly for v1

@courtneyholcomb courtneyholcomb merged commit ad64e01 into main May 11, 2024
41 of 43 checks passed
@courtneyholcomb courtneyholcomb deleted the court/avoid branch May 11, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants