Skip to content

Commit

Permalink
Improve log again (#1377)
Browse files Browse the repository at this point in the history
Last improvement for this log didn't actually help because the data set,
when printed, does not display any of its properties. Printing the
instance sets instead.
  • Loading branch information
courtneyholcomb authored Aug 21, 2024
1 parent f14daee commit ee061f1
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions metricflow/plan_conversion/dataflow_to_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -925,8 +925,9 @@ def visit_combine_aggregated_outputs_node(self, node: CombineAggregatedOutputsNo
assert all(
[set(x.data_set.instance_set.spec_set.linkable_specs) == set(linkable_specs) for x in join_data_sets]
), (
"All join data sets should have the same set of linkable instances as the from dataset since all values are coalesced. "
f"Got from dataset: {from_data_set}\nGot join datasets: {join_data_sets}"
"All join data sets should have the same set of linkable instances as the from dataset since all values are coalesced.\n"
f"From dataset instance set: {from_data_set.data_set.instance_set}\n"
f"Join dataset instance sets: {[join_data_set.data_set.instance_set for join_data_set in join_data_sets]}"
)

linkable_spec_set = from_data_set.data_set.instance_set.spec_set.transform(SelectOnlyLinkableSpecs())
Expand Down

0 comments on commit ee061f1

Please sign in to comment.