Skip to content

Commit

Permalink
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion metricflow/plan_conversion/dataflow_to_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,10 @@ def visit_combine_aggregated_outputs_node(self, node: CombineAggregatedOutputsNo
linkable_specs = from_data_set.data_set.instance_set.spec_set.linkable_specs
assert all(
[set(x.data_set.instance_set.spec_set.linkable_specs) == set(linkable_specs) for x in join_data_sets]
), "All parent nodes should have the same set of linkable instances since all values are coalesced."
), (
"All join data sets should have the same set of linkable instances as the from dataset since all values are coalesced. "
f"Got from dataset: {from_data_set}\nGot join datasets: {join_data_sets}"
)

linkable_spec_set = from_data_set.data_set.instance_set.spec_set.transform(SelectOnlyLinkableSpecs())
join_type = SqlJoinType.CROSS_JOIN if len(linkable_spec_set.all_specs) == 0 else SqlJoinType.FULL_OUTER
Expand Down

0 comments on commit f14daee

Please sign in to comment.