Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch SCD example to entity type natural #4629

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Switch SCD example to entity type natural #4629

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52c289c
Switch SCD example to entity type `natural`
tlento Dec 12, 2023
62def67
Apply suggestions from code review
tlento Dec 12, 2023
b163859
Merge branch 'current' into tlento-scd-natural-key
matthewshaver Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions website/docs/docs/build/dimensions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ This example shows how to create slowly changing dimensions (SCD) using a semant
| 333 | 2 | 2020-08-19 | 2021-10-22|
| 333 | 3 | 2021-10-22 | 2048-01-01|

Take note of the extra arguments under `validity_params`: `is_start` and `is_end`. These arguments indicate the columns in the SCD table that contain the start and end dates for each tier (or beginning or ending timestamp column for a dimensional value).
Take note of the extra arguments under `validity_params`: `is_start` and `is_end`. These arguments indicate the columns in the SCD table that contain the start and end dates for each tier (or beginning or ending timestamp column for a dimensional value). Note also the entity is tagged as `natural` - this is to distinguish it from a `primary` entity, where we expect one row per entity value. Here, we expect one row per entity value/validity window combination.
tlento marked this conversation as resolved.
Show resolved Hide resolved

```yaml
semantic_models:
Expand Down Expand Up @@ -282,7 +282,7 @@ semantic_models:

entities:
tlento marked this conversation as resolved.
Show resolved Hide resolved
- name: sales_person
type: primary
type: natural
expr: sales_person_id
```

Expand Down
Loading